New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gang Store Consistency #259

Merged
merged 6 commits into from Apr 20, 2017

Conversation

4 participants
@J4Wx
Contributor

J4Wx commented Jan 27, 2017

On each map, the first gang store encountered does not include the additional arguments for nearestObjects, resulting in issues with the store if additional items have been placed.

Changes proposed in this pull request:

  • Add these additional arguments to the gang store missing them.

@BoGuu BoGuu added the In Progress label Jan 27, 2017

@Jawshy Jawshy added the bug-fix label Jan 27, 2017

@Jawshy Jawshy added this to TODO in v5.0.0 Jan 29, 2017

@BoGuu

This comment has been minimized.

Show comment
Hide comment
@BoGuu

BoGuu Feb 1, 2017

Member

LGTM, thanks

Member

BoGuu commented Feb 1, 2017

LGTM, thanks

@WolfSkin1337
@BoGuu

This comment has been minimized.

Show comment
Hide comment
@BoGuu

BoGuu Feb 5, 2017

Member

I can see that this could be an issue, but I'm wondering what objects that class as buildings are exactly causing the issues? Unless you place things further away from the hideout itself. Can you confirm?

Member

BoGuu commented Feb 5, 2017

I can see that this could be an issue, but I'm wondering what objects that class as buildings are exactly causing the issues? Unless you place things further away from the hideout itself. Can you confirm?

@J4Wx J4Wx closed this Feb 11, 2017

@BoGuu BoGuu removed the In Progress label Feb 11, 2017

@J4Wx J4Wx reopened this Apr 17, 2017

@BoGuu BoGuu added the In Progress label Apr 17, 2017

J4Wx added some commits Apr 17, 2017

@BoGuu

This comment has been minimized.

Show comment
Hide comment
@BoGuu

BoGuu Apr 20, 2017

Member

LGTM, thanks :)

Member

BoGuu commented Apr 20, 2017

LGTM, thanks :)

@BoGuu BoGuu merged commit 7bb7ad4 into AsYetUntitled:master Apr 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@BoGuu BoGuu removed the In Progress label Apr 20, 2017

@Jawshy Jawshy moved this from TODO to Done in v5.0.0 Oct 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment