New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fn_fetchPlayerHouses.sqf (never-ending pushback bug) #294

Merged
merged 4 commits into from Apr 16, 2017

Conversation

Projects
None yet
5 participants
@fresqo
Contributor

fresqo commented Mar 11, 2017

Resolves #.
the _containerss array would muliply for ALL crates and keep updating the next house and the next house with multiple pushbacked crates. eventually if u have like 3 houses and 1 crate in each the third house would have all crates in its "containers" variable, disabling adding more crates due to limits.

Changes proposed in this pull request:

  • reassign the array by getting the "containers" variable each crate

@BoGuu BoGuu added the In Progress label Mar 11, 2017

@BoGuu

This comment has been minimized.

Show comment
Hide comment
@BoGuu

BoGuu Mar 11, 2017

Member

Good spot. This file is absolutely horrible in general ;)

Member

BoGuu commented Mar 11, 2017

Good spot. This file is absolutely horrible in general ;)

@setoy

This comment has been minimized.

Show comment
Hide comment
@setoy

setoy Mar 12, 2017

Contributor

HC-Server is missing. Otherwise good spot :)

Contributor

setoy commented Mar 12, 2017

HC-Server is missing. Otherwise good spot :)

fresqo added some commits Mar 12, 2017

Update fn_fetchPlayerHouses.sqf
im unsure the purpose of the below..... apart from another SVAR in queryRequest i dont see it being called, which could make line 84 and 87 useless. 
missionNamespace setVariable [format ["houses_%1",_uid],_return];
@fresqo

This comment has been minimized.

Show comment
Hide comment
@fresqo

fresqo Mar 12, 2017

Contributor

Could someone please double check for me the use of ...
missionNamespace setVariable [format ["houses_%1",_uid],_return];
i do not see a need for it.

Contributor

fresqo commented Mar 12, 2017

Could someone please double check for me the use of ...
missionNamespace setVariable [format ["houses_%1",_uid],_return];
i do not see a need for it.

@NiiRoZz

This comment has been minimized.

Show comment
Hide comment
@NiiRoZz

NiiRoZz Mar 18, 2017

Contributor

It's my container system, when i was scripted this, i was dirty time, reworked all house system, more optimized ...

Contributor

NiiRoZz commented Mar 18, 2017

It's my container system, when i was scripted this, i was dirty time, reworked all house system, more optimized ...

@fresqo

This comment has been minimized.

Show comment
Hide comment
@fresqo

fresqo Mar 24, 2017

Contributor

So you will update the system? @NiiRoZz

Contributor

fresqo commented Mar 24, 2017

So you will update the system? @NiiRoZz

@NiiRoZz

This comment has been minimized.

Show comment
Hide comment
@NiiRoZz

NiiRoZz Mar 27, 2017

Contributor

@fresqo i'm working, on it, yes

Contributor

NiiRoZz commented Mar 27, 2017

@fresqo i'm working, on it, yes

@BoGuu

This comment has been minimized.

Show comment
Hide comment
@BoGuu

BoGuu Apr 16, 2017

Member

Will clean the file up in due course. Thanks!

Member

BoGuu commented Apr 16, 2017

Will clean the file up in due course. Thanks!

@BoGuu BoGuu merged commit fd1a642 into master Apr 16, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@BoGuu BoGuu removed the In Progress label Apr 16, 2017

@BoGuu BoGuu deleted the fresqo-patch-1 branch Jun 25, 2017

@Jawshy Jawshy added the bug-fix label Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment