Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server function cleanup (Changing all BIS_fnc_Param with Param/Params) #576

Open
wants to merge 122 commits into
base: master
from

Conversation

@koalas11
Copy link

commented Sep 11, 2019

Resolves #Function with BIS_fnc_Param.

Changes proposed in this pull request:

  • Changing all BIS_fnc_Param with Param/Params and removing or adding missing variable or useless one + optimization. Checked for errors when starting the server no errors found but still need a better check
  • I have tested my changes and corrected any errors found

koalas11 added 2 commits Sep 11, 2019
there are 2 variable with the same name _vInfo just a really small update to remove one
@koalas11 koalas11 changed the title Remove of a duplicate private variable Remove of a duplicate private variable and a useless variable in fn_insertVehicle.sqf Sep 15, 2019
koalas11 added 3 commits Sep 15, 2019
@koalas11 koalas11 changed the title Remove of a duplicate private variable and a useless variable in fn_insertVehicle.sqf Remove of useless variable/useless lines in code Sep 15, 2019
koalas11 added 17 commits Sep 16, 2019
Changed BIS_fnc_Param with Params added _pipe as a private variable
@koalas11 koalas11 changed the title Remove of useless variable/useless lines in code server function cleanup (Changing all BIS_fnc_Param with Param/Params) Sep 18, 2019
koalas11 added 5 commits Sep 18, 2019
koalas11 added 2 commits Sep 27, 2019
2 Files need a rework to be optimized:
fn_cleanup.sqf
fn_initHouses.sqf
koalas11 added 2 commits Sep 30, 2019
Tried to remove most of _query variable that weren't necessary
Copy link
Contributor

left a comment

In life_server/Functions/MySQL/fn_asyncCall.sqf

if ((_queryResult select 0) isEqualTo 0) exitWith {diag_log format ["extDB3: Protocol Error: %1", _queryResult];};

Have you tested your changes for the given error case?
This function is intended to return an array (see: https://github.com/AsYetUntitled/Framework/search?q=db_fnc_asyncCall&type=Code)

koalas11 added 4 commits Oct 2, 2019
Copy link
Contributor

left a comment

The FSM files are only intended to be edited from within the FSM Editor application provided in Arma 3 Tools, are you sure these changes work?

@koalas11

This comment has been minimized.

Copy link
Author

commented Oct 3, 2019

For now the changes on the FSM doesn't give any error on startup but i will do some more testing soon

koalas11 added 3 commits Oct 3, 2019
@koalas11

This comment has been minimized.

Copy link
Author

commented Oct 3, 2019

ok remade the FSM files with arma tools

koalas11 added 6 commits Oct 6, 2019
@koalas11 koalas11 requested a review from klmunday Oct 7, 2019
koalas11 added 7 commits Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.