Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major Cleanup rework #611

Merged
merged 14 commits into from Feb 24, 2020
Merged

Major Cleanup rework #611

merged 14 commits into from Feb 24, 2020

Conversation

@BlackFisch
Copy link
Contributor

BlackFisch commented Feb 11, 2020

Changes proposed in this pull request:

  • move dead vehicle cleanup to EntityKilled-Eventhandler

  • configurable delay and minimum distance to next player before despawning (Config_Master.hpp)

  • reworked death logging

  • moved group cleanup to fn_cleanup.sqf

  • remove cleanup.fsm and all occurences in code

  • configurable distance between players and vehicles before despawning it

  • automated group deletion with deleteGroupWhenEmpty

  • I have tested my changes and corrected any errors found

Copy link
Member

DomT602 left a comment

Some initial comments :)

life_hc/MySQL/General/fn_cleanup.sqf Outdated Show resolved Hide resolved
life_hc/MySQL/General/fn_cleanup.sqf Outdated Show resolved Hide resolved
life_server/Functions/Systems/fn_cleanup.sqf Outdated Show resolved Hide resolved
life_hc/MySQL/General/fn_cleanup.sqf Outdated Show resolved Hide resolved
Copy link
Contributor

klmunday left a comment

As long as this is all tested and behaves as intended then I have no issues with this except for the specific comment

@BlackFisch

This comment has been minimized.

Copy link
Contributor Author

BlackFisch commented Feb 24, 2020

So, what about this PR? :) Any news?

@Jason2605 Jason2605 merged commit 3339bb5 into AsYetUntitled:master Feb 24, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@BlackFisch BlackFisch deleted the BlackFisch:cleanup-rework branch Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.