Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract touch bar firmware #173

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WhatAmISupposedToPutHere

Signed-off-by: Sasha Finkelstein fnkl.kernel@gmail.com

Copy link
Member

@marcan marcan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and I really like how you implemented the conversion from plist to something the kernel can parse. Just a few comments.

asahi_firmware/multitouch.py Outdated Show resolved Hide resolved
asahi_firmware/multitouch.py Outdated Show resolved Hide resolved
asahi_firmware/multitouch.py Outdated Show resolved Hide resolved
asahi_firmware/multitouch.py Show resolved Hide resolved
asahi_firmware/multitouch.py Outdated Show resolved Hide resolved
@marcan
Copy link
Member

marcan commented Jan 23, 2023

Also FYI: We missed this in the early installer versions (even in the raw firmware tarball), so people who installed on M1MBP prior to when we added M2 support will have to do a stub reinstall/firmware re-extract for this to work. I'll probably finally implement stub upgrades in the installer with the 13.2 support release, so that will probably be ready by the time the touch bar is usable anyway.

Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants