kboot: adjust max-link-speed for 10GE Mac Mini #125
Conversation
|
A simpler alternative to this m1n1 change would be to increase "max-link-speed" unconditionally in the dts. The gigabit ethernet Mac Mini model works with that change. |
There was a problem hiding this comment.
I'm confused as to how this was tested, since the Linux aPCIE driver currently ignores max-link-speed entirely as far as I can tell. :)
I think that if the 1GE version doesn't have issues down-negotiating from Gen4 (with my patch in that actually makes Gen>1 work), then for now it's probably easier to just let it try up to that unconditionally, so we wouldn't need this code. However, we should certainly keep this branch around in case it becomes more useful in the future :)
|
I tested only the device tree rewriting by using a dtb with |
jannau
force-pushed
the
mac-mini-10gb-pci
branch
from
36e2904
to
96c5eba
Compare
Modifies just "max-link-speed" although the template ADT for J274 has different values for "pci-max-payload-size" and "pci-aspm-default". The "lan-10gb" sub node has an additional property "function-pcie_port_control". Signed-off-by: Janne Grunau <j@jannau.net>
jannau
force-pushed
the
mac-mini-10gb-pci
branch
from
96c5eba
to
271d1e7
Compare
|
Closing since it is unnecessary since m1n1 sets the link speed based on the ADT since abee2ec |
Modifies just "max-link-speed" although the template ADT for J274 has
different values for "pci-max-payload-size" and "pci-aspm-default".
The "lan-10gb" sub node has an additional property
"function-pcie_port_control".
Signed-off-by: Janne Grunau j@jannau.net