New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonevtloop mode + perl module #90

Open
wants to merge 25 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@kbin76

kbin76 commented Jun 20, 2017

Hi,
what do you think of this?

I've removed all my json generation (also removed dependencies on gson library) in favour of what you pushed the other day.

I also added some convenience functionality to your json data output, for instance now it always emits additional timestamp in readable ISO utc format and the groups name if it's a group message. The latter which in turn resulted in the need for having Manager object in creation of JsonGroupInfo object.

However I felt that this wasn't properly belonging under "daemon" option, so it's still invoked using it's own special "jsonevtloop" command.

Currently the JSON output is quite more complex than what is expected as JSON input, I'v prefer if the input would mirror the output in terms of JSON schema, but otoh that would be uneccessary complex (keep it simple).

Perl module is under perl/ with a couple of example scripted bots.

BR
Kalle

@thefinn93

This comment has been minimized.

Contributor

thefinn93 commented Sep 10, 2017

Is there something preventing this from getting merged? I'd love to build on top of it, but not if it's going to undergo changes before merge.

thefinn93 and others added some commits Dec 4, 2017

@skorokithakis

This comment has been minimized.

skorokithakis commented Dec 5, 2018

I realize this is pretty old, but would you mind merging the current master into your branch, @kbin76, so we can use your fork? I really need this functionality but this PR hasn't gotten any replies.

/cc @AsamK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment