Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonevtloop mode + perl module #90

Closed
wants to merge 0 commits into from
Closed

jsonevtloop mode + perl module #90

wants to merge 0 commits into from

Conversation

@kbin76
Copy link

@kbin76 kbin76 commented Jun 20, 2017

Hi,
what do you think of this?

I've removed all my json generation (also removed dependencies on gson library) in favour of what you pushed the other day.

I also added some convenience functionality to your json data output, for instance now it always emits additional timestamp in readable ISO utc format and the groups name if it's a group message. The latter which in turn resulted in the need for having Manager object in creation of JsonGroupInfo object.

However I felt that this wasn't properly belonging under "daemon" option, so it's still invoked using it's own special "jsonevtloop" command.

Currently the JSON output is quite more complex than what is expected as JSON input, I'v prefer if the input would mirror the output in terms of JSON schema, but otoh that would be uneccessary complex (keep it simple).

Perl module is under perl/ with a couple of example scripted bots.

BR
Kalle

@thefinn93
Copy link
Contributor

@thefinn93 thefinn93 commented Sep 10, 2017

Is there something preventing this from getting merged? I'd love to build on top of it, but not if it's going to undergo changes before merge.

@skorokithakis
Copy link

@skorokithakis skorokithakis commented Dec 5, 2018

I realize this is pretty old, but would you mind merging the current master into your branch, @kbin76, so we can use your fork? I really need this functionality but this PR hasn't gotten any replies.

/cc @AsamK

@AsamK AsamK force-pushed the AsamK:master branch 3 times, most recently from 6358b00 to 1df8622 Sep 11, 2019
@kbin76 kbin76 closed this Feb 8, 2020
@kbin76 kbin76 force-pushed the kbin76:master branch from fc30d53 to f3ecddb Feb 8, 2020
@kbin76
Copy link
Author

@kbin76 kbin76 commented Feb 9, 2020

I closed this pull request and created a new one where I have re-implemeted this functionality. It was not possible to merging the current master into my old branch, so i had to start from scratch again (more or less).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants