Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse hover over an item on the map would show quantity and name #246

Closed
Superspyi opened this issue Jun 4, 2020 · 6 comments · Fixed by #385
Closed

Mouse hover over an item on the map would show quantity and name #246

Superspyi opened this issue Jun 4, 2020 · 6 comments · Fixed by #385
Assignees
Labels
feature request New and valid feature request
Projects

Comments

@Superspyi
Copy link

Is your feature request related to a problem? Please describe.
It would be nice when you hover over an item in game that it would show the amount of the item and then the item name.

Describe the solution you'd like
Add some sort of feature that allows a mouse hover over an item to show the quantity and the name. Would probably be similar to the same way mouse hover on player, npc, or event will show the brackets around them. Example of what it would say - 300 Gold - 2 Health Potion - Snake Rattle

Additional context
mouse hover item

@Cheshire92
Copy link
Contributor

Curious what if situation, what do you propose would happen if there's more than one item on the map in one location?

Only show the top item? Show them all?

@ghost
Copy link

ghost commented Jun 9, 2020

I think I could report in this format if more than one type of item
First Line: Quanty ItemName
Second line: ...

Ex:
13 Gold
...

or

First Line: Quanty ItemName
Second: x others ...

Ex:
First Line: 13 Gold
Second: 3 others ...

@Superspyi
Copy link
Author

I've only seen it implemented as the top item shows the name on hover. But the idea of having a separate line for each item doesn't seem to bad. My only worry is with more than 2-3 items it could definitely start to look messy. Maybe just the top item is the way to go. Or maybe something toggleable in a config file or something.

@Cheshire92
Copy link
Contributor

Cheshire92 commented Oct 7, 2020

Not exactly done yet, but I've got a start.
image

Currently this kind of chaos ensues when there's multiple items next to eachother though.
image2

https://github.com/Azurebeats/Intersect-Engine/tree/DrawMapItemNames

Little note to myself, the order items are rendered in on the map is not the order you pick them up in..

@Cheshire92 Cheshire92 self-assigned this Oct 7, 2020
@Cheshire92 Cheshire92 added this to the Beta 7 milestone Oct 7, 2020
@Cheshire92 Cheshire92 added the feature request New and valid feature request label Oct 7, 2020
@Richy1111
Copy link

Richy1111 commented Oct 7, 2020

Oh jeez I was about to propose to just have it show the first item until picked up, but now that idea sounds bad if there's no rendering/pickup order. :(
On mouse hover could probably solve the multiple map item names next to each other, to show/hide. But it would still show the entire stack of names if on the same tile.

@Cheshire92
Copy link
Contributor

Fixed the rendering order just now, and got the mouseover logic to work.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New and valid feature request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants