Fix at secondaryDamage #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… transform MP damaging in MP healing
|
Could you please write an issue for the problem? |
|
@Cheshire92 done #957 :) |
This was referenced Oct 16, 2021
jcsnider
pushed a commit
that referenced
this pull request
Mar 28, 2022
… transform MP damaging in MP healing (#949)
lodicolo
pushed a commit
that referenced
this pull request
Mar 28, 2022
… transform MP damaging in MP healing (#949)
jcsnider
pushed a commit
that referenced
this pull request
Mar 29, 2022
… transform MP damaging in MP healing (#949)
jcsnider
pushed a commit
that referenced
this pull request
Mar 29, 2022
… transform MP damaging in MP healing (#949)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #957
Fix when trying to swap targets HP and MP and when target MPs defense transform MP damaging in MP healing.
Basically that baseDamage is setted by HP damage only. So when trying to swap targets HP into MP, the damagingAttack is true since HP damage > 0 and MP is < 0, then MP is just setted to 0.
In another case, if the damage calculation brings an damaging MP attack below 0, the damagingAttack is false because there is no HP damage, so the secondaryDamage is not setted to 0 turning an MP damage in a MP healing.