Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved other buttons #18

Closed
grumpygeek opened this issue Dec 8, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@grumpygeek
Copy link

commented Dec 8, 2017

It caused some buttons to move to far left (I had arrows, reload etc on right), and some were dropped into Customize palette. I did not try and trace any exact cause, just reverted to a profile backup. I realize this info is not of much use, sorry.

@Ascrod Ascrod self-assigned this Dec 8, 2017

@Ascrod Ascrod added the bug label Dec 8, 2017

@Ascrod

This comment has been minimized.

Copy link
Owner

commented Dec 8, 2017

Got a few reports of this on the forum. I'm reverting 3fb4985 and releasing a new version until I have more time to troubleshoot this.

@grumpygeek

This comment has been minimized.

Copy link
Author

commented Dec 8, 2017

I think the customize menu may be caused by some other extension (actually can't find out what is causing it). So I edited the title and first post for this.

@grumpygeek grumpygeek changed the title Moved other buttons, disabled Customize Moved other buttons Dec 8, 2017

@Ascrod

This comment has been minimized.

Copy link
Owner

commented Dec 10, 2017

Have done some testing on this, and I think it just comes down to how each extension (or the browser) positions its buttons on application startup. It can be a messy system, and sometimes they just don't always play nicely with each other. I especially noticed this with some restartless add-on buttons.

Fortunately, If you do see this happen after installing Reader View, it should only be a one-time event. You will have to rearrange your UI once before it sticks, and it should stay that way... assuming other extensions don't mess with it later.

Once installed, the add-on sets a preference in about:config to remind itself to not to not add the button to the UI again. This preference stays in your browser's config even if you uninstall the extension (as a side effect of how Firefox and derivative browsers handle extension preferences). So as long as you do not delete or reset that preference manually, you should not see your UI change again, even if you uninstall and reinstall later.

HTH. I've commited 051aa3b to reintroduce this functionality, and it should be a bit more stable now. I'll do some more testing and will probably release 1.0.2 tomorrow.

@grumpygeek

This comment has been minimized.

Copy link
Author

commented Dec 10, 2017

Worked nicely this time, inserted just after url box.

@grumpygeek grumpygeek closed this Dec 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.