New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve localization #21

Open
Ascrod opened this Issue Dec 29, 2017 · 3 comments

Comments

2 participants
@Ascrod
Owner

Ascrod commented Dec 29, 2017

Most of the localization files are missing a property for "readerView.disabled", which displays in a tooltip on the Reader View button when it is grayed out. In English, the tooltip says "Reader View Unavailable". I've added some preliminary translations for several locales, but these are very rough and likely need to be proofread by native speakers.

Suggestions and pull requests for this are more than welcome!

@Ascrod Ascrod self-assigned this Dec 29, 2017

@Ascrod Ascrod removed their assignment Jan 11, 2018

@FranklinDM

This comment has been minimized.

Show comment
Hide comment
@FranklinDM

FranklinDM Apr 4, 2018

Contributor

Hi @Ascrod, I have submitted PR #30 for a few edits to the TL locale.

Contributor

FranklinDM commented Apr 4, 2018

Hi @Ascrod, I have submitted PR #30 for a few edits to the TL locale.

@Ascrod

This comment has been minimized.

Show comment
Hide comment
@Ascrod

Ascrod Apr 4, 2018

Owner

Thanks! There are a few features on the way that will require some further localization updates, and I was hoping to finish them before merging the PR in. I'll update this issue and the thread on the forum when those become available.

Owner

Ascrod commented Apr 4, 2018

Thanks! There are a few features on the way that will require some further localization updates, and I was hoping to finish them before merging the PR in. I'll update this issue and the thread on the forum when those become available.

@Ascrod

This comment has been minimized.

Show comment
Hide comment
@Ascrod

Ascrod Apr 7, 2018

Owner

To follow up on my last comment, I have added a new feature for showing and hiding images. This includes two new strings in the properties file here.

Owner

Ascrod commented Apr 7, 2018

To follow up on my last comment, I have added a new feature for showing and hiding images. This includes two new strings in the properties file here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment