Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show original URL in location bar #7

Closed
Ascrod opened this issue Dec 4, 2017 · 3 comments

Comments

Projects
None yet
1 participant
@Ascrod
Copy link
Owner

commented Dec 4, 2017

If possible, show the original URL when in Reader Mode. See if urlbar bindings can be implemented.

@Ascrod Ascrod added the bug label Dec 4, 2017

@Ascrod Ascrod self-assigned this Dec 4, 2017

@Ascrod Ascrod changed the title Entering Reader Mode shows about:reader URL instead of original page URL Show original URL in location bar Dec 4, 2017

@Ascrod

This comment has been minimized.

Copy link
Owner Author

commented Dec 7, 2017

If possible, add a setter to urlbar.onBeforeValueSet without replacing the existing one.

See also: https://bugzilla.mozilla.org/show_bug.cgi?id=1123910

@Ascrod

This comment has been minimized.

Copy link
Owner Author

commented Jan 17, 2018

After looking at this, it might be possible to just hide the about:reader URL in the location bar. Hoping to achieve the exact same level of integration as Firefox (e.g. mail integration), however, would be impractical if not impossible without breaking things internal to the browser.

Instead of trying to do this, it might be easier to just provide a means to copy the original URL without having to close Reader View.

@Ascrod

This comment has been minimized.

Copy link
Owner Author

commented Feb 8, 2018

Closing this issue as WONTFIX for now. Rather than possibly breaking things or causing confusion over how the URL is displayed or used, it should be easy enough to obtain the original URL by using the original article's link at the top of the page or by exiting Reader Mode.

@Ascrod Ascrod closed this Feb 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.