Skip to content

Commit

Permalink
Rename to TelegramQml
Browse files Browse the repository at this point in the history
  • Loading branch information
realbardia committed Jun 21, 2015
1 parent 14e0d11 commit 1fa3b6b
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions qmldir
@@ -1,3 +1,3 @@
module TelegramQML
plugin TelegramQML
module TelegramQml
plugin TelegramQml

2 changes: 1 addition & 1 deletion telegramqml.pro
Expand Up @@ -4,7 +4,7 @@ CONFIG += qt
QT += qml quick sql xml multimedia
DEFINES += TELEGRAMQML_LIBRARY

uri = TelegramQML
uri = TelegramQml

win32 {
QT += winextras
Expand Down
2 changes: 1 addition & 1 deletion telegramqml_plugin.cpp
Expand Up @@ -3,7 +3,7 @@

#include <qqml.h>

void TelegramQMLPlugin::registerTypes(const char *uri)
void TelegramQmlPlugin::registerTypes(const char *uri)
{
// @uri com.mycompany.qmlcomponents
TelegramQmlInitializer::init(uri);
Expand Down
2 changes: 1 addition & 1 deletion telegramqml_plugin.h
Expand Up @@ -3,7 +3,7 @@

#include <QQmlExtensionPlugin>

class TelegramQMLPlugin : public QQmlExtensionPlugin
class TelegramQmlPlugin : public QQmlExtensionPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
Expand Down

2 comments on commit 1fa3b6b

@kalikiana
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just spotted this change by chance. What's the sense of this rename? Why have QML in the name of a QML plugin in the first place? There is no way this can be re-used outside of the QML world so it's inherently redundant.

@mkarnicki
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps because it's easier for us to reference that this way whereas Telegram is also a class in libqtelegram.

Please sign in to comment.