Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.3 Icons not showing in backend panel #434

Closed
a-h-abid opened this Issue Nov 14, 2017 · 34 comments

Comments

Projects
None yet
@a-h-abid
Copy link

a-h-abid commented Nov 14, 2017

Summary of issue

Icons are not showing in admin panel. Some error are showing in the Console.

chrome_2017-11-14_15-17-22

Steps to reproduce

Install a fresh Asgard v3.3 and visit the backend admin panel.

System Details

  • Operating System: Windows 10 Pro
  • PHP Version: 7.1.6
  • Laravel Version: 5.5.x
  • Asgardcms/Platform version: 3.3.x
@a-h-abid

This comment has been minimized.

Copy link
Author

a-h-abid commented Nov 14, 2017

Hello, it seems the font-awesome font files you included with the project are somehow corrupted. I downloaded a fresh font-awesome copy and replaced only the fonts. Now all icons are showing and those errors were gone.

@a-h-abid a-h-abid closed this Nov 14, 2017

@nWidart

This comment has been minimized.

Copy link
Member

nWidart commented Nov 18, 2017

Hello,
This is an annoying issue that I wasn't able to fix even after re-installing fontawesome etc.

However, I've tried something new now, to remove the files, commit that, and re-add them via npm afterwards. This change is on the 3.0 branch and hopefully works now.

@Naoray

This comment has been minimized.

Copy link

Naoray commented Nov 20, 2017

Facing the same issue... is there going to be a fix?

@nWidart

This comment has been minimized.

Copy link
Member

nWidart commented Nov 20, 2017

Yes, read my message before yours.

@Naoray

This comment has been minimized.

Copy link

Naoray commented Nov 20, 2017

how can I specify which branch to download when using composer create-project asgardcms/platform your-project-name for installation?

@joshbrw

This comment has been minimized.

@Naoray

This comment has been minimized.

Copy link

Naoray commented Nov 20, 2017

@joshbrw why not updating the latest version of asgardcms to include this bugfix?

@joshbrw

This comment has been minimized.

Copy link
Member

joshbrw commented Nov 20, 2017

@nWidart will release a new version when he feels he should @Naoray

@Naoray

This comment has been minimized.

Copy link

Naoray commented Nov 20, 2017

@joshbrw ok, sorry for asking.

@nWidart

This comment has been minimized.

Copy link
Member

nWidart commented Nov 20, 2017

@Naoray

This comment has been minimized.

Copy link

Naoray commented Nov 20, 2017

@nWidart thanks!

@Naoray

This comment has been minimized.

Copy link

Naoray commented Nov 22, 2017

@nWidart still not working.. Am I missing something?

image

@nWidart

This comment has been minimized.

Copy link
Member

nWidart commented Nov 22, 2017

I heard yes. I don't know how to fix the issue.

@nWidart nWidart reopened this Nov 22, 2017

@nWidart nWidart added the Help Wanted label Nov 22, 2017

@a-h-abid

This comment has been minimized.

Copy link
Author

a-h-abid commented Nov 22, 2017

@nWidart Do you remember since when you and people are having this problem? Just a guess, maybe some commit is causing this issue... Maybe if you can figure out that commit and revert it, then it might work out.

@tehuel

This comment has been minimized.

Copy link

tehuel commented Nov 24, 2017

I'm having the same problem on a fresh v3.4.0 installation 😞.

imagen

However, on Firefox im not seeing any error on console. Also i've deleted and replaced the font awesome files inside \public\themes\adminlte\vendor\font-awesome AND public\fonts\vendor\font-awesome with no luck fixing it.

@richardfeliciano

This comment has been minimized.

Copy link

richardfeliciano commented Nov 26, 2017

Dudes, i`ve manage to fix downloading the fonts on http://fontawesome.io/ and replacing it on /themes/adminlte/vendor/font-awesome/fonts

@motchju

This comment has been minimized.

Copy link
Contributor

motchju commented Dec 1, 2017

@richardfeliciano thanks for the workaround 👍

@matijakovacevic

This comment has been minimized.

@a-h-abid

This comment has been minimized.

Copy link
Author

a-h-abid commented Dec 7, 2017

@nWidart Look into the link posted by @matijakovacevic . I think this may solve your problem.

Might be because in your .gitattributes file of adminlte-theme you set the font files attributes to text, after a git checkout it is messing with the files.

@darron1217

This comment has been minimized.

Copy link
Contributor

darron1217 commented Dec 8, 2017

How about utilizing CDN?

For performance + stability :)
https://cdnjs.com/libraries/font-awesome

@nWidart

This comment has been minimized.

Copy link
Member

nWidart commented Dec 8, 2017

Indeed, you maybe even upgrade to v5 while at it. https://fontawesome.com/how-to-use/upgrading-from-4

@LIU0472

This comment has been minimized.

Copy link

LIU0472 commented Dec 27, 2017

@nWidart

git config --global core.autocrlf false
@ivansammartino

This comment has been minimized.

Copy link

ivansammartino commented Feb 4, 2018

Having the same problem, and let just an idea as @darron1217 suggested: you could link all those "static" CSS and JS assets from a CDN... please, can you add this?

@wildcard27

This comment has been minimized.

Copy link

wildcard27 commented Feb 6, 2018

The only way I have got around this is replacing the font URLs in the CSS to use the Font Awesome CDNs Can we get a proper fix for this please?

@ivansammartino

This comment has been minimized.

Copy link

ivansammartino commented Feb 6, 2018

Looking at code I found an easy way to switch local assets with CDN ones, without touching Blade templates.
Go to config/asgard/core/core.php file and look for the "admin-assets" array.
Replace your local asset (i.e. 'font-awesome.css' => ['theme' => 'vendor/font-awesome/css/font-awesome.min.css'],) with a CDN one ('font-awesome.css' => ['cdn' => 'https://maxcdn.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css'],)

@Husky110

This comment has been minimized.

Copy link

Husky110 commented Feb 9, 2018

And I just wonder why we still have to patch arround instead of getting a fix... ;)

@nWidart

This comment has been minimized.

Copy link
Member

nWidart commented Feb 10, 2018

The fork button is at the top right.

@yassabdulrhamn

This comment has been minimized.

Copy link

yassabdulrhamn commented Feb 11, 2018

Dears,
Try this, it used work with me

For Laravel >= 5.5

Run npm install font-awesome --save
Add @import "~font-awesome/scss/font-awesome.scss"; in resources/assets/saas/app.scss
Run npm run dev (or npm run watch or even npm run production)

https://stackoverflow.com/questions/43451509/how-to-install-font-awesome-in-laravel-mix

@pleone

This comment has been minimized.

Copy link

pleone commented Feb 18, 2018

Thanks @yassabdulrhamn , it worked for me!

@bl3

This comment has been minimized.

Copy link

bl3 commented Feb 25, 2018

The solution for me was to compile the assets for the adminlte theme

  • cd /Themes/Adminlte
  • npm install
  • npm run production
@chiragpipariya

This comment has been minimized.

Copy link
Contributor

chiragpipariya commented Feb 27, 2018

First
Go to below file and make it 'hideDefaultLocaleInURL' => false,
config/laravellocalization.php

than
do set below all code in .htaccess file
`

Options -MultiViews

RewriteEngine On

# Redirect Trailing Slashes...
RewriteRule ^(.*)/$ /$1 [L,R=301]

RewriteRule ^(themes|modules|css|js|fonts|assets)/(.*) /public/$1/$2 [L]

# Handle Front Controller...
RewriteCond %{REQUEST_FILENAME} !-d
RewriteCond %{REQUEST_FILENAME} !-f
RewriteRule ^ /public/index.php [L]
` i hope this work for you i done this problem by this
@AgustinJimenez

This comment has been minimized.

Copy link

AgustinJimenez commented Mar 11, 2018

@nWidart

This comment has been minimized.

Copy link
Member

nWidart commented Mar 14, 2018

A fix was finally released regarding this issue.

Fontawesome is now being served via a cdn.

https://github.com/AsgardCms/Platform/releases/tag/3.5.2

@nWidart nWidart closed this Mar 14, 2018

@MirShaon

This comment has been minimized.

Copy link

MirShaon commented Nov 7, 2018

.main-header .sidebar-toggle:before {
font-family: "Font Awesome 5 Free";
font-weight: 900;
content: "\f0c9";
}

Add bunch of css in AdminLTE.css then it will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.