New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Undefined offset error on saving settings #343 #453

Closed
wants to merge 1 commit into
base: 3.0
from

Conversation

Projects
None yet
2 participants
@darron1217
Contributor

darron1217 commented Jan 11, 2018

This PR exlcudes GET parameters from SettingController's store method.
Issue #343

@nWidart

This comment has been minimized.

Show comment
Hide comment
@nWidart

nWidart Jan 11, 2018

Member

It's strange to me that this was never reported before, and that I can't reproduce this issue.
What is causing the need for this specifically now? (Yes, I've read your issue)

Member

nWidart commented Jan 11, 2018

It's strange to me that this was never reported before, and that I can't reproduce this issue.
What is causing the need for this specifically now? (Yes, I've read your issue)

@darron1217

This comment has been minimized.

Show comment
Hide comment
@darron1217

darron1217 Jan 11, 2018

Contributor

@nWidart
I'm currently using Nginx for webserver, and if Nginx is running with the settings below,
image

This problem can be reproduced

Contributor

darron1217 commented Jan 11, 2018

@nWidart
I'm currently using Nginx for webserver, and if Nginx is running with the settings below,
image

This problem can be reproduced

@nWidart

This comment has been minimized.

Show comment
Hide comment
@nWidart

nWidart Jan 13, 2018

Member

Hello,

After some further thought into this, I don't think this should be merged in.
It looks like a server setup on your end to make it work with laravel.

If you need to use $request->request->all(), that means that the whole cms would break because we use $request->all() everywhere.

Member

nWidart commented Jan 13, 2018

Hello,

After some further thought into this, I don't think this should be merged in.
It looks like a server setup on your end to make it work with laravel.

If you need to use $request->request->all(), that means that the whole cms would break because we use $request->all() everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment