Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Jul 09, 2014

  1. Merge "Fix the section name in CONTRIBUTING.rst"

    Jenkins authored openstack-gerrit committed

Jul 08, 2014

  1. John Dickinson

    Merge tag '2.0.0'

    Swift 2.0.0 release
    
    Change-Id: I5fdc1e7434bdf6d88c4b260798791ee59f0832c0
    notmyname authored
  2. Merge "This setting should've been set to False back ..."

    Jenkins authored openstack-gerrit committed
  3. Greg Holt

    This setting should've been set to False back ...

    ...with commit 9eb797b
    
    With this setting to True in the code, any tools anyone writes will
    automatically start preallocating, which is almost always bad these days
    with SSDs. So, if you write a tool that just scan dbs for stats, it'll
    commit any pending info triggering preallocation and bam, your SSDs
    start to fill up. :/
    
    Anyway, back when I wrote 9eb797b it
    was my intention to have this off by default, everywhere; I changed all
    the settings points but I failed to change the dang constant itself.
    This corrects that.
    
    Change-Id: Iada0a3f1ecfabda4a96f574903d8e2eed1f69064
    gholt authored
  4. Document the unnecessary method invoking in FakeRing

    Add comment to explain why we invoke the get_part method even if the
    _part_shift is equal to 32.
    
    Closes-Bug:  #1335581
    
    Change-Id: I160e9383b5e65f75ed5e89511cc7e63c51958a25
    yummybian authored cschwede committed
  5. Merge "Parallel object auditor"

    Jenkins authored openstack-gerrit committed
  6. Merge "Use except x as y instead of except x, y"

    Jenkins authored openstack-gerrit committed
  7. Merge "Sync netifaces with global-requirements"

    Jenkins authored openstack-gerrit committed

Jul 07, 2014

  1. Christian Berendt

    Use except x as y instead of except x, y

    According to https://docs.python.org/3/howto/pyporting.html the
    syntax changed in Python 3.x. The new syntax is usable with
    Python >= 2.6 and should be preferred to be compatible with Python3.
    
    Enabled hacking check H231.
    
    Change-Id: I2c41dc3ec83e79181e8fd50e76771a74c393269c
    berendt authored smerritt committed

Jul 04, 2014

  1. Merge "Mock time for audit test 'test_sleeper'"

    Jenkins authored openstack-gerrit committed
  2. Merge "Fix issues with test_wsgi.py and Storage Policies"

    Jenkins authored openstack-gerrit committed

Jul 03, 2014

  1. Merge "Fix exception raising in FakeConn"

    Jenkins authored openstack-gerrit committed
  2. Paul Luse

    Fix potential missing key error in container_info

    If upgrading from a non-storage policy enabled version of
    swift to a storage policy enabled version its possible that
    memcached will have an info structure that does not contain
    the 'storage_policy" key resulting in an unhandled exception
    during the lookup.  The fix is to simply make sure we never
    return the dict without a storage_policy key defined; if it
    doesn't exist its safe to make it '0' as this means you're
    in the update scenario and there's xno other possibility.
    
    Change-Id: If8c88f67ba7a3180ad06b586372fe35c65807aac
    peluse authored notmyname committed
  3. clayg

    Fix pop_queue for move object twice

    With the two vector timestamp change some resolution was lost in the queue
    entries that could lead to the reconciler being unable to successfully remove
    a processed item from the queue in pop_queue.  To ensure the queue entries
    with a significant offset can be successfully removed while still handling
    the re-enqueued object case issue the DELETE with the timestamp slightly later
    than the maximum of the queue entries last modified time (q_record) and
    misplaced objects timestamp (q_ts).
    
    Change-Id: I87b1e4b4256af3f71defb58c8137c303d1ae63be
    clayg authored notmyname committed
  4. clayg

    Fix KeyError on Storage Policy Container Sync

    In the proxy, container_info can return a 'storage_policy' of None.  When
    you set a header value on a swob.Request to None that effectively just
    delete's the key.  One path through the proxy during container sync was
    counting on the the 'X-Backend-Storage-Policy-Index' being set which isn't
    the case if the cached container_info if for a pre-policies container.
    
    Also clean up some test cruft, tighten up the interface on FakeConn, and add
    some object controller tests to exercise more interesting failure and handoff
    code paths.
    
    Change-Id: I643e08c208efdc5a39e840d9e96710ddad54236b
    clayg authored notmyname committed
  5. Merge "Small cleanup to ring serialization"

    Jenkins authored openstack-gerrit committed
  6. Merge "Fix potential missing key error in container_info"

    Jenkins authored openstack-gerrit committed
  7. Merge "Fix pop_queue for move object twice"

    Jenkins authored openstack-gerrit committed

Jul 02, 2014

  1. Paul Luse

    Fix potential missing key error in container_info

    If upgrading from a non-storage policy enabled version of
    swift to a storage policy enabled version its possible that
    memcached will have an info structure that does not contain
    the 'storage_policy" key resulting in an unhandled exception
    during the lookup.  The fix is to simply make sure we never
    return the dict without a storage_policy key defined; if it
    doesn't exist its safe to make it '0' as this means you're
    in the update scenario and there's xno other possibility.
    
    Change-Id: If8e8f66d32819c5bfb2d1308e14643f3600ea6e9
    peluse authored clayg committed
  2. Sam Merritt

    Fix exception raising in FakeConn

    Timeout isn't an Exception, so Timeouts in tests weren't getting
    raised. Instead, you'd sometimes have an HTTPResponse's .status be a
    Timeout object, not an integer, which greatly confuses code that
    expects an integer.
    
    Also reorder the test that exposed the failure in the gate so it blows
    up most times instead of sometimes do demonstrate the failure with out
    this fix to FakeConn.
    
    Change-Id: I76367a0575f84cad6b2f03e814f3f16bf96bc7d1
    smerritt authored clayg committed
  3. clayg

    Fix order dependent test in proxy.test_server

    TestObjectController.test_POST_backend_headers was being too picky about the
    order of backend requests which when pushed through eventlet will not have a
    stable order.  This change preserves the expectations and assertions while
    removing the dependency on the order of the requests.
    
    Change-Id: I7176ccb9223cd3dfc3c922b8b3d81eb514891d05
    clayg authored
  4. clayg

    Fix pop_queue for move object twice

    With the two vector timestamp change some resolution was lost in the queue
    entries that could lead to the reconciler being unable to successfully remove
    a processed item from the queue in pop_queue.  To ensure the queue entries
    with a significant offset can be successfully removed while still handling
    the re-enqueued object case issue the DELETE with the timestamp slightly later
    than the maximum of the queue entries last modified time (q_record) and
    misplaced objects timestamp (q_ts).
    
    Change-Id: I4726243b3f7c4c1e98f0c578e7ffdecf4ec22199
    clayg authored notmyname committed
  5. Greg Holt

    SimpleClient http proxying

    Previously, this code was attempting to set up http proxying but it
    wasn't working. We noticed after a while when we saw traffic going
    through an alternate route instead of our set of http proxies with
    container sync.
    
    Additional work and testing by clayg; thanks!
    
    Change-Id: I840b8e55a80c13ae85c65bf68de261d735685b27
    gholt authored

Jul 01, 2014

  1. Merge "Add test for swift-recon --auditor"

    Jenkins authored openstack-gerrit committed
  2. Merge "Fix SLO test with old simplejson"

    Jenkins authored openstack-gerrit committed
  3. Merge "Container Auditor should log a warning if the devices path con…

    …tains a non-directory."
    Jenkins authored openstack-gerrit committed
  4. Fix the section name in CONTRIBUTING.rst

    The name of the section "If you're developer, start here"
    has changed in the wiki, now is "If you're a developer".
    This commit updates it to correctly refer to the
    proper section.
    
    Change-Id: I724107362c7eaf895133ab0a902a575081c025be
    liuqing authored smerritt committed
  5. Sam Merritt

    Small cleanup to ring serialization

    Instead of catching TypeError and retrying without mtime, let's just
    check and see if mtime is an allowed arg and decide based on
    that. This way, if anything else raises TypeError we'll know about it.
    
    Change-Id: Ib394d8176e2bc4bd53ace019ce5816369223c273
    smerritt authored
  6. Merge "Add SAIO fix for Ubuntu 12.04"

    Jenkins authored openstack-gerrit committed
  7. Container Auditor should log a warning if the devices path contains a…

    … non-directory.
    
    If the devices path configured in container-server.conf contains a file
    then an uncaught exception is seen in the logs. For example if file foo exists as such
    /srv/1/node/foo then when the container-auditor runs, the exception that foo/containers is
    not a directory is seen in the logs
    
    This patch was essentially clayg and can be found in the bug
    
    I tested it and wanted to get a feel of the openstack workflow so going through the
    commit process
    
    I have added a unit test as well as cleaned up and improved the unit test coverage
    for this module.
    - unit test for above fix is added
    - unit test to verify exceptions that are raised in the module
    - unit test to verify the logger's behavior
    - unit test to verify mount_check behavior
    
    Change-Id: I903b2b1e11646404cfb0551ee582a514d008c844
    Closes-Bug: #1317257

Jun 30, 2014

  1. clayg

    Fix KeyError on Storage Policy Container Sync

    In the proxy, container_info can return a 'storage_policy' of None.  When
    you set a header value on a swob.Request to None that effectively just
    delete's the key.  One path through the proxy during container sync was
    counting on the the 'X-Backend-Storage-Policy-Index' being set which isn't
    the case if the cached container_info if for a pre-policies container.
    
    Also clean up some test cruft, tighten up the interface on FakeConn, and add
    some object controller tests to exercise more interesting failure and handoff
    code paths.
    
    Change-Id: Ic379fa62634c226cc8a5a4c049b154dad70696b3
    clayg authored
  2. Matthew Oliver

    Add SAIO fix for Ubuntu 12.04

    The version of setup tools in Ubuntu 12.04 is too old and is causing
    the SAIO instructions to fail when installing python-swiftclient.
    
    The work around is to install python-swiftclient's dependencies
    before running running:
    
      python setup.py develop
    
    This change adds a note to users of Ubuntu 12.04 to replace step 2
    of "Getting the code" with:
    
      cd $HOME/python-swiftclient; sudo pip install -r requirements.txt; \
                                   python setup.py develop; cd -
    
    Change-Id: I63f57bbf1f1158f8740f6137ad55ff49f12a316c
    Closes-Bug: #1217288

Jun 26, 2014

  1. clayg

    Fix double request in simple client

    The SimpleClient.base_request method need only to call urllib2.urlopen
    once to get a response from the server.  Remove the duplicate call.
    
     * fixup tests that were poorly mocking urllib2
     * mock eventlet sleep because we're all busy
    
    Change-Id: I6da93c689200351e9dbd9416b9c4bf9544571f15
    clayg authored

Jun 25, 2014

  1. Merge "Fix some spelling in comments"

    Jenkins authored openstack-gerrit committed
  2. Merge "Fix swift-recon --auditor bug"

    Jenkins authored openstack-gerrit committed
Something went wrong with that request. Please try again.