Remove obsolete 'mem' metric

AsherBond · May 29, 2013 · 50ad978 · 50ad978
1 parent c1078c0
commit 50ad978
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 9 deletions.
diff --git a/collector/lib/collector/handler.rb b/collector/lib/collector/handler.rb
@@ -88,9 +88,6 @@ def additional_tags
     # Called by the collector to process the varz. Processes common
     # metric data and then calls process() to add subclass behavior.
     def do_process
-      # TODO: "mem" probably isn't used and should be removed
-      send_metric("mem", @varz["mem"] / 1024) if @varz["mem"]
-
       send_metric("mem_free_bytes", @varz["mem_free_bytes"]) if @varz["mem_free_bytes"]
       send_metric("mem_used_bytes", @varz["mem_used_bytes"]) if @varz["mem_used_bytes"]
       send_metric("cpu_load_avg", @varz["cpu_load_avg"]) if @varz["cpu_load_avg"]

diff --git a/collector/spec/unit/collector/handler_spec.rb b/collector/spec/unit/collector/handler_spec.rb
@@ -39,12 +39,6 @@
       handler.do_process()
     end
 
-    it "sends out 'mem' if specified" do
-      handler = Collector::Handler.new(nil, nil, nil, nil, {"mem" => 2048})
-      handler.should_receive(:send_metric).with("mem", 2)
-      handler.do_process
-    end
-
     it "sends out 'mem_used_bytes' if specified" do
       handler = Collector::Handler.new(nil, nil, nil, nil, {"mem_used_bytes" => 2048})
       handler.should_receive(:send_metric).with("mem_used_bytes", 2048)