New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused using statements #2

Closed
Ashera138 opened this Issue Oct 3, 2018 · 8 comments

Comments

Projects
None yet
3 participants
@Ashera138
Owner

Ashera138 commented Oct 3, 2018

Issue: There are many using statements throughout the files in this project that aren't being used. These should be removed.

This is a small and easy issue specifically for 馃尡 new contributors 馃尡 to try so they can get the hang of the contribution process rather than the contribution itself.

If you need a guide on how to contribute, check out this README.

If you have any questions or get stuck, feel free to comment below and I will answer all questions as best I can! 馃尀

@Ashera138 Ashera138 changed the title from Removed unused using statements to Remove unused using statements Oct 3, 2018

@Ashera138 Ashera138 assigned Ashera138 and unassigned Ashera138 Oct 3, 2018

Zaksh added a commit to Zaksh/ADHDmail that referenced this issue Oct 4, 2018

@Zaksh Zaksh referenced this issue Oct 4, 2018

Merged

Removed unused using statements #3

4 of 9 tasks complete

@Ashera138 Ashera138 closed this in #3 Oct 4, 2018

@Ashera138 Ashera138 reopened this Nov 7, 2018

@Ashera138

This comment has been minimized.

Owner

Ashera138 commented Nov 7, 2018

This issue is open again for any new contributors who want to give it a try!

@Ashera138 Ashera138 closed this Nov 13, 2018

@Ashera138 Ashera138 reopened this Nov 15, 2018

@Ashera138 Ashera138 closed this in c9eb787 Nov 16, 2018

@Ashera138 Ashera138 reopened this Nov 16, 2018

@lvictorino

This comment has been minimized.

lvictorino commented Nov 17, 2018

Hey @Ashera138 you re opened this but I couldn't find any unused using statement on Master branch :S

@Ashera138

This comment has been minimized.

Owner

Ashera138 commented Nov 18, 2018

@lvictorino There are some in the ADHDmailTests project. :)

@Ashera138

This comment has been minimized.

Owner

Ashera138 commented Nov 19, 2018

At a glance, GlobalValues.cs (which is new) has some that can be removed. And in the test project, there's ExtensionsTests and both of these files.

Anyone is welcome to this.

@lvictorino

This comment has been minimized.

lvictorino commented Nov 19, 2018

I'll do it if that's ok.

@santhoshrajr

This comment has been minimized.

Contributor

santhoshrajr commented Nov 23, 2018

@Ashera138 is the issue still Open?

@Ashera138

This comment has been minimized.

Owner

Ashera138 commented Nov 23, 2018

@santhoshrajr Yep! Feel free to submit a PR for it.

santhoshrajr added a commit to santhoshrajr/ADHDmail that referenced this issue Nov 23, 2018

Ashera138 added a commit that referenced this issue Nov 23, 2018

Merge pull request #15 from santhoshrajr/removeusings
Removed extra using statements for issue #2
@Ashera138

This comment has been minimized.

Owner

Ashera138 commented Nov 23, 2018

I'll open this back up when I see more again. 馃憤

@Ashera138 Ashera138 closed this Nov 23, 2018

@Ashera138 Ashera138 reopened this Nov 26, 2018

Repository owner deleted a comment from Zaksh Nov 26, 2018

Repository owner deleted a comment from Colton-Bouchard Nov 26, 2018

Repository owner deleted a comment from Colton-Bouchard Nov 26, 2018

@Ashera138 Ashera138 closed this in bd843ca Nov 28, 2018

@Ashera138 Ashera138 reopened this Nov 30, 2018

@Ashera138 Ashera138 closed this in bd31278 Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment