Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@Asleeepp
Copy link
Owner

1.6 is a MASSIVE update for skript-itemsadder, pretty much overhauling the entire addon.

Including an entire aliases system, there are a ton of new things, breaking changes (obviously). Its probably the last update ill do for a while.

@Asleeepp Asleeepp self-assigned this Aug 16, 2024
Copy link

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issues i have highlighted are usually common across multiple files. i would recommend going through each of them, keeping the recommendations i have left in mind.

other general thoughts:

  • doesn't seem necessary to have a package named "other". i would just remove it and bump everything in it up

@Florenthz
Copy link

Hi, can you add something to use:
"on rightclick with custom item:"?
Greetings

@Asleeepp
Copy link
Owner Author

Hi, can you add something to use: "on rightclick with custom item:"? Greetings

You should just be able to use:

on right click:
    if player's tool is an itemsadder item with id "namespaced:id":
        # do stuff

@Asleeepp Asleeepp merged commit 46954b2 into master Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants