This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
suggested changes
Aug 16, 2024
APickledWalrus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the issues i have highlighted are usually common across multiple files. i would recommend going through each of them, keeping the recommendations i have left in mind.
other general thoughts:
- doesn't seem necessary to have a package named "other". i would just remove it and bump everything in it up
src/main/java/me/asleepp/SkriptItemsAdder/SkriptItemsAdder.java
Outdated
Show resolved
Hide resolved
src/main/java/me/asleepp/SkriptItemsAdder/elements/conditions/CondGetAction.java
Outdated
Show resolved
Hide resolved
src/main/java/me/asleepp/SkriptItemsAdder/elements/conditions/CondHUDExists.java
Show resolved
Hide resolved
src/main/java/me/asleepp/SkriptItemsAdder/elements/conditions/CondHUDIsVisible.java
Outdated
Show resolved
Hide resolved
src/main/java/me/asleepp/SkriptItemsAdder/elements/conditions/CondHUDIsVisible.java
Outdated
Show resolved
Hide resolved
src/main/java/me/asleepp/SkriptItemsAdder/elements/expressions/ExprCropAge.java
Outdated
Show resolved
Hide resolved
src/main/java/me/asleepp/SkriptItemsAdder/other/util/UpdateChecker.java
Outdated
Show resolved
Hide resolved
src/main/java/me/asleepp/SkriptItemsAdder/elements/conditions/CondCooldown.java
Outdated
Show resolved
Hide resolved
|
Hi, can you add something to use: |
Owner
Author
You should just be able to use: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.6 is a MASSIVE update for skript-itemsadder, pretty much overhauling the entire addon.
Including an entire aliases system, there are a ton of new things, breaking changes (obviously). Its probably the last update ill do for a while.