Add ability for custom headers #168

Merged
merged 2 commits into from Apr 25, 2013

Projects

None yet

3 participants

@griffindy

building off of the work here: #120

all I did was add a test, which should hopefully be sufficient. If it's not, just let me know what else I can add.

@davidjrice

Please rebase this, hopefully the build will pass and we can look at getting this merged in. Thanks.

@griffindy

so it appears that Object#remove_const does not remove the loaded file from the $" variable, which is what require checks against when loading a file. Therefore require 'mime/types' was returning false, implying that the module was already loaded, when in fact the constant had been removed.

this seems like a bug in ruby, though I've added a fix to delete the appropriate entry from $". Coincidentally I think this may also be the cause of the other failing spec that you later marked as pending.

@davidjrice davidjrice merged commit 63566b2 into AssetSync:master Apr 25, 2013

1 check passed

Details default The Travis build passed
@davidjrice
@griffindy

@davidjrice thanks for merging in my pull request! As for loading the gems, if you really need to fully delete something and re require it, just remember to move the corresponding file(s) from $".

@jjb

Great to see this -- could someone write some docs in the readme to show how to use it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment