Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Waiting to Happen #149

Merged
merged 1 commit into from Jun 25, 2018
Merged

Error Waiting to Happen #149

merged 1 commit into from Jun 25, 2018

Conversation

Deantwo
Copy link
Collaborator

@Deantwo Deantwo commented Jun 25, 2018

Setting the Reconnect property would always result in it becoming true.
While this seem like a neat party trick, it will likely just make someone want to murder you someday.

Changed:

public bool Reconnect
{
    get { return this.reconnect; }
    set { this.reconnect = true; }
}

to:

public bool Reconnect
{
    get { return this.reconnect; }
    set { this.reconnect = value; }
}

Changed the strange `true` to `value`.
@skrusty skrusty merged commit 82724c1 into AsterNET:master Jun 25, 2018
@Deantwo Deantwo deleted the patch-3 branch September 20, 2018 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants