[Install pages] Adapt support table width to full container width #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he current max 15 item support table
|
Thanks for all the efforts and recording the videos and everything :D |
|
Downsides needing fix:
|
…tus colors to work as text background
|
New design to remove the downsides of previuos approach.
|
|
Looks very cool, great work! Thank you @eLtMosen |
FlorentRevest
approved these changes
Mar 5, 2023
@dodoradio greatly helped to polish it! |
|
Thanks dodo too! Just a note, it seems that you introduced a stray "Preparation" title before "Choose your variant" in the MTK6580 watches page https://asteroidos.org/install/harmony/ |
|
https://asteroidos.org/install/beluga/ also has a stray "Hardware Support" :) |
This was referenced Mar 5, 2023
eLtMosen
added a commit
to eLtMosen/asteroidos.org
that referenced
this pull request
Mar 9, 2023
…teroidOS#253) * Introduce table-support class with responsive behaviour tailored to the current max 15 item support table * Assign new table-support class to all install pages * [aw-install-dual] Implement new div based design for the support table * [aw-install-multi] Implement new div based design for the support table * [aw-install] Implement new div based design for the support table * [aw-install-simg] Implement new div based design for the support table * [beluga-install] Implement new div based design for the support table * [mtk-install] Implement new div based design for the support table * [mooneye-install] Implement new div based design for the support table * Add install-support-col, define new feature status div, and adapt status colors to work as text background * Remove border and fix tool tips visibility vs display to not occupy space when hidden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support table was fixed width and looked off after adding the model number table.
This PR
This method prevents horizontal scrolling down to a minimum screen width of 520px.
Before
support-table-before-2023-03-02_14.31.02.mp4
After, for current worst case catfish
support-table-after-2023-03-02_14.59.07.mp4