feat(sql)!: Dont force ansi dialect #1628
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
The original configuration for
sqlfluffadd an extra--dialect ansiargument to the null_ls configuration, forcing the use of ANSI dialect. This is very annoying since it will override the dialect set in the configuration file.sqlfluffand leave little options for the user to use their desired dialect. With this change I remove that extra argument. However, this also means that the user must create a.sqlflufffile in the folder and specify the dialect there. I might adjust the README file to reflect this.--dialect ansiextra argument frominit.luaAdditional Information