Skip to content

feat(sql)!: Dont force ansi dialect #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 29, 2025
Merged

feat(sql)!: Dont force ansi dialect #1628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b1b09d
fix(sql): Remove forced ansi dialect for sqlfluff
CongLuanTran Aug 25, 2025
9bd9565
fix(sql): Modify README to add instruction for `sqlfluff`
CongLuanTran Aug 27, 2025
7550627
Update README.md
Uzaaft Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lua/astrocommunity/pack/sql/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ This plugin pack does the following:
- `go` must be in your `PATH` and executable.
- formatting is disabled due to https://github.com/sqls-server/sqls/issues/149
- Adds [sqls.nvim](https://github.com/nanotee/sqls.nvim) for language specific tooling
- Adds `sqlfluff` for both formatting and linting (using the ANSI dialect)
- Adds [sqlfluff](https://docs.sqlfluff.com) for both formatting and linting
8 changes: 2 additions & 6 deletions lua/astrocommunity/pack/sql/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,8 @@ return {

opts.handlers.sqlfluff = function()
local null_ls = require "null-ls"
null_ls.register(null_ls.builtins.diagnostics.sqlfluff.with {
extra_args = { "--dialect", "ansi" },
})
null_ls.register(null_ls.builtins.formatting.sqlfluff.with {
extra_args = { "--dialect", "ansi" },
})
null_ls.register(null_ls.builtins.diagnostics.sqlfluff)
null_ls.register(null_ls.builtins.formatting.sqlfluff)
end
end,
},
Expand Down