-
-
Notifications
You must be signed in to change notification settings - Fork 302
fix(markdown-preview-nvim): Change build command to download prebuilt version of markdown-preview. #1640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
|
This is just an alternative method on how to build this, I dont see what advantage it will provide over the current approach. |
|
Yup. But the current method doesn't works with asdf. |
|
I dont get how. How doesnt it work with asdf. Whats the error. |
lua/astrocommunity/markdown-and-latex/markdown-preview-nvim/init.lua
Outdated
Show resolved
Hide resolved
Uzaaft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deep dove into the code, yeah this is smarter tbh. Rewrote the command to use the one from the official docs with lazy instrucions
|
Sorry for the slow reply. Here is the error when I run |
Use this new build command to build markdown-preview. Fix tslib module not found when npm is installed by asdf.
📑 Description
ℹ Additional Information
Link to the author: iamcco/markdown-preview.nvim#690 (comment)