Skip to content

Conversation

@std-enigma
Copy link
Contributor

Rebinds the dismiss keybinding to be which is a common convention in vim/nvim to close a popup menu

Closes #1564

@github-actions
Copy link

github-actions bot commented Sep 20, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@Uzaaft
Copy link
Member

Uzaaft commented Sep 23, 2025

Isnt the dismiss more often <C-e> and not <C-E>

@std-enigma
Copy link
Contributor Author

Yes, it is — but the only reason I chose this was that the other bindings for this plugin were all in capital case, so I figured that’s what people were used to.

@Uzaaft
Copy link
Member

Uzaaft commented Sep 23, 2025

I think it should be lowercase e, to be inline with "defaults"

@std-enigma
Copy link
Contributor Author

Done

I think it should be lowercase e, to be inline with "defaults"

Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Uzaaft Uzaaft changed the title fix(copilot-lua-cmp): keymap conflict fix(copilot-lua-cmp): rebind dismiss keybinding to avoid keymap conflict Sep 27, 2025
@Uzaaft Uzaaft merged commit 31ddaa3 into AstroNvim:main Sep 27, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copilot-lua-cmp: change C-c mapping

2 participants