Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #23

Merged
merged 6 commits into from Jul 16, 2019

Conversation

@FlYos
Copy link
Contributor

commented Jul 15, 2019

Small refactoring for improve readability

FlYos and others added some commits Jul 15, 2019

@Gummibeer

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

Hey,
thanks for your proposal. Could you merge the current master into your branch to make CircleCI work again?
Except of this I don't want to introduce a new public method for this. Because it's only needed for the translation relation I would make it private.

@Gummibeer Gummibeer self-assigned this Jul 15, 2019

@Gummibeer

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

@FlYos thanks for the fast adjustments! :)
Will release it in the next release. I think that it will be this week - just have to check if I can release something else with it.

@Gummibeer Gummibeer merged commit 4025c0f into Astrotomic:master Jul 16, 2019

8 checks passed

Scrutinizer Analysis: 2 new issues, 1 updated code elements – Tests: passed
Details
WIP Ready for review
Details
ci/circleci: build-php72-laravel56 Your tests passed on CircleCI!
Details
ci/circleci: build-php72-laravel57 Your tests passed on CircleCI!
Details
ci/circleci: build-php72-laravel58 Your tests passed on CircleCI!
Details
ci/circleci: build-php73-laravel58 Your tests passed on CircleCI!
Details
codeclimate All good!
Details
continuous-integration/styleci/pr The analysis has passed
Details
@Gummibeer

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.