Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule factory #34

Merged
merged 9 commits into from Aug 7, 2019

Conversation

@Gummibeer
Copy link
Member

commented Jul 29, 2019

replaces: #26

Gummibeer added some commits Jul 29, 2019

@Gummibeer Gummibeer added the feature label Jul 29, 2019

@Gummibeer Gummibeer self-assigned this Jul 29, 2019

Gummibeer added some commits Jul 29, 2019

@FlYos

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

Hey @Gummibeer,

I looked at your code, I haven't yet had the opportunity to test it, but that seems to me correct in relation to our discussion.

Maybe add a parameter in the package configuration to change the prefix and suffix globally? Same for the type of format used.

@Gummibeer

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

@FlYos have some time now and will add the default delimiter configuration values.

Gummibeer added some commits Aug 7, 2019

@FlYos

FlYos approved these changes Aug 7, 2019

@Gummibeer

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

Will release it as v11.3.0 - have to add a v11.2.1 because of #40

@FlYos

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

@Gummibeer perfect 👌thx a lot for this job.

@Gummibeer

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

@FlYos no problem! Have to thank you for the feature request and input. :)

@Gummibeer Gummibeer merged commit 26c28c6 into master Aug 7, 2019

9 checks passed

Scrutinizer Analysis: 1 updated code elements – Tests: passed
Details
WIP Ready for review
Details
ci/circleci: build-php72-laravel56 Your tests passed on CircleCI!
Details
ci/circleci: build-php72-laravel57 Your tests passed on CircleCI!
Details
ci/circleci: build-php72-laravel58 Your tests passed on CircleCI!
Details
ci/circleci: build-php73-laravel58 Your tests passed on CircleCI!
Details
codeclimate All good!
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details

@Gummibeer Gummibeer deleted the ft-rule-factory branch Aug 7, 2019

@FlYos

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

@Gummibeer with pleasure ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.