Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto fallback feature #36

Merged
merged 24 commits into from Aug 7, 2019

Conversation

@Gummibeer
Copy link
Member

commented Jul 31, 2019

follow up: #35

netdown and others added some commits Jul 30, 2019

Update Translatable.php
Add auto fallback feature (use first available locale as fallback locale), can be activated by setting fallback_locale to null.
Codeclimate
Avoid too many return statements within this method - return null removed, makes no difference.
G
GG
Merge pull request #35 from netdown/master
Add auto fallback feature

@Gummibeer Gummibeer added the feature label Jul 31, 2019

@Gummibeer Gummibeer self-assigned this Jul 31, 2019

Merge remote-tracking branch 'remotes/origin/master' into ft-auto-fal…
…lback

# Conflicts:
#	tests/TranslatableTest.php

@Gummibeer Gummibeer merged commit 4396600 into master Aug 7, 2019

8 of 9 checks passed

codeclimate 3 issues to fix
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
WIP Ready for review
Details
ci/circleci: build-php72-laravel56 Your tests passed on CircleCI!
Details
ci/circleci: build-php72-laravel57 Your tests passed on CircleCI!
Details
ci/circleci: build-php72-laravel58 Your tests passed on CircleCI!
Details
ci/circleci: build-php73-laravel58 Your tests passed on CircleCI!
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details

@Gummibeer Gummibeer deleted the ft-auto-fallback branch Aug 7, 2019

@Gummibeer

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

@netdown again thanks for your work! And sorry for the delay. Had some issues with GitBook to merge changelog and also a lot to do.
It's now merged and released as https://github.com/Astrotomic/laravel-translatable/releases/tag/v11.2.0

@netdown

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

@Gummibeer Great! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.