[Feat] Add appIcon #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
리젝 사유일 수 있지만.. 일단 스위프트 로고가 있는것을 사용해보려합니다!
Collaborator
|
흰색 공백 없이 꽉 채우는건 어떤가요?? |
unnnyong
reviewed
Sep 9, 2022
| "size" : "83.5x83.5" | ||
| }, | ||
| { | ||
| "filename" : "1024.png", |
Collaborator
There was a problem hiding this comment.
이제 1024px 사이즈 하나면 된다고 했던 기억이 나서 검색해보니까 Xcode 14부터였네요 😢 ...
다음 버전 배포 때는 1024px만 남기고 삭제해서 앱 용량 줄여보아요 ~~~ !
Collaborator
Author
There was a problem hiding this comment.
오 그런게 되는군요! 엑스코드 얼른 업뎃하고싶네요! 곧 정식릴리즈 될것같은데~~
unnnyong
approved these changes
Sep 9, 2022
Collaborator
|
저 Approve하고보니 각자 다른 이야기하고 있는데 어떡하죠 ?,,, @song-cool |
Collaborator
|
@unnnyong 제 기억이 맞다면 아마도 review 철회 가능할겁니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
리젝 사유일 수 있지만.. 일단 스위프트 로고가 있는것을 사용해보려합니다!