[Feat] JsonParsing #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
diff --git a/AsyncSwift/Observed/EventDetailView+Observed.swift b/AsyncSwift/Observed/EventDetailView+Observed.swift
index cf01070..a91b44c 100644
--- a/AsyncSwift/Observed/EventDetailView+Observed.swift
+++ b/AsyncSwift/Observed/EventDetailView+Observed.swift
@@ -11,7 +11,11 @@ import EventKit
extension EventDetailView {
final class Observed: ObservableObject {
- @Published var event = Event()
+ init(event: Event) {
+ self.event = event
+ }
+
+ @Published var event: Event
@Published var isShowingSheet = false
@Published var isShowingAddEventConfirmationAlert = false
@Published var isShowingAddEventSuccessAlert = false
diff --git a/AsyncSwift/Views/EventDetailView.swift b/AsyncSwift/Views/EventDetailView.swift
index 4cb63d1..3bc215d 100644
--- a/AsyncSwift/Views/EventDetailView.swift
+++ b/AsyncSwift/Views/EventDetailView.swift
@@ -9,10 +9,10 @@ import SwiftUI
struct EventDetailView: View {
- @StateObject var observed = Observed()
+ @ObservedObject var observed: Observed
init(event: Event) {
-// self.observed.event = event
+ self.observed = Observed(event: event)
}
var body: some View { |
예정된 행사, 진행중인 행사, 지나간 행사를 계산하고 화면을 그려주는 기능
- struct Event 의 type: String 이라는 property 추가
- sessionDetail 을 Hstack에 넣어 좌측으로 밀었습니더
unnnyong
reviewed
Sep 13, 2022
unnnyong
reviewed
Sep 13, 2022
- Padding, Stack 등을 수정 디자인이 미흡하게 반영된 허점을 수정하였습니다
unnnyong
reviewed
Sep 14, 2022
unnnyong
reviewed
Sep 14, 2022
unnnyong
reviewed
Sep 14, 2022
unnnyong
reviewed
Sep 14, 2022
unnnyong
reviewed
Sep 14, 2022
unnnyong
reviewed
Sep 14, 2022
unnnyong
reviewed
Sep 14, 2022
| .font(.title3) | ||
| .fontWeight(.semibold) | ||
| .padding(.vertical, 24) | ||
| VStack(alignment: .leading, spacing: 8) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| VStack(alignment: .leading, spacing: 8) { | |
| VStack(alignment: .leading) { |
8이 default value였던 것 같아서 생략 가능할까요 ?
unnnyong
reviewed
Sep 14, 2022
- Struct 구조 수정 - EventView+Observed 내부 변수 수정
- Portraint Mode Only - Light Mode Only
- 최최최최최최초ㅣ종
unnnyong
reviewed
Sep 14, 2022
|
|
||
| import Foundation | ||
|
|
||
| struct Event: Codable { |
Collaborator
There was a problem hiding this comment.
IMO로 get만 할 때는 Decodable도 되지 않을까 싶네요
unnnyong
reviewed
Sep 14, 2022
| guard let self = self else { return } | ||
| do { | ||
| let decodedData = try JSONDecoder().decode(Event.self, from: data) | ||
| withAnimation { |
Collaborator
There was a problem hiding this comment.
이게 트리거로 멋진 애니메이션이 나오는거였군요 👾
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json fetch 후 view에 data를 전달하는 구조로 refactoring 하였습니다
struct 를 codable 로 수정하였고 요청에 의해 구조가 수정되었습니다