[Feat] Add StampView #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unnnyong
reviewed
Sep 8, 2022
unnnyong
reviewed
Sep 8, 2022
unnnyong
reviewed
Sep 8, 2022
unnnyong
reviewed
Sep 8, 2022
unnnyong
reviewed
Sep 8, 2022
unnnyong
reviewed
Sep 8, 2022
unnnyong
reviewed
Sep 8, 2022
AsyncSwift/Views/StampView.swift
Outdated
Comment on lines
65
to
79
| if isFlipped { | ||
| withAnimation(.linear(duration: durationAndDelay)) { | ||
| backDegree = 90 | ||
| } | ||
| withAnimation(.linear(duration: durationAndDelay).delay(durationAndDelay)) { | ||
| frontDegree = 0 | ||
| } | ||
| } else { | ||
| withAnimation(.linear(duration: durationAndDelay)) { | ||
| frontDegree = -90 | ||
| } | ||
| withAnimation(.linear(duration: durationAndDelay).delay(durationAndDelay)) { | ||
| backDegree = 0 | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Suggested change
| if isFlipped { | |
| withAnimation(.linear(duration: durationAndDelay)) { | |
| backDegree = 90 | |
| } | |
| withAnimation(.linear(duration: durationAndDelay).delay(durationAndDelay)) { | |
| frontDegree = 0 | |
| } | |
| } else { | |
| withAnimation(.linear(duration: durationAndDelay)) { | |
| frontDegree = -90 | |
| } | |
| withAnimation(.linear(duration: durationAndDelay).delay(durationAndDelay)) { | |
| backDegree = 0 | |
| } | |
| } | |
| withAnimation(.linear(duration: durationAndDelay)) { | |
| frontDegree = isFlipped ? 90 : -90 | |
| } | |
| withAnimation(.linear(duration: durationAndDelay).delay(durationAndDelay)) { | |
| backDegree = 0 | |
| } |
사망연산자를 씁시다 ~~~ ! 깔깔
Collaborator
Author
There was a problem hiding this comment.
if 문을 연속으로 작동해야하는 코드이기에 분리 유지 하겠습니다!
Collaborator
There was a problem hiding this comment.
코드에 주석으로도 남겨주시면 좋을 것 같아요 ..
song-cool
reviewed
Sep 8, 2022
unnnyong
reviewed
Sep 8, 2022
unnnyong
reviewed
Sep 8, 2022
unnnyong
reviewed
Sep 8, 2022
song-cool
reviewed
Sep 8, 2022
unnnyong
reviewed
Sep 8, 2022
song-cool
requested changes
Sep 8, 2022
Collaborator
song-cool
left a comment
song-cool
left a comment
There was a problem hiding this comment.
리뷰 완료했습니다. 뷰빌더관련 코드를 살펴보아서 좋았습니다!
고생하셨습니다 :)
몇몇가지 디자인 수정사항들을 발견하여 수정요청 드립니다!
unnnyong
reviewed
Sep 8, 2022
AsyncSwift/Views/StampView.swift
Outdated
| } // body | ||
|
|
||
| //MARK: Flip Card Function | ||
| func flipCard () { |
Collaborator
There was a problem hiding this comment.
private extension으로 옮기면 어때..요..???
song-cool
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add Ticket at StampView
Description