Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KQueueEventLoopGroup is ignored #1575

Closed
jamel opened this issue Sep 2, 2018 · 3 comments · Fixed by #1665
Closed

KQueueEventLoopGroup is ignored #1575

jamel opened this issue Sep 2, 2018 · 3 comments · Fixed by #1665

Comments

@jamel
Copy link

jamel commented Sep 2, 2018

Here it is

if (eventLoopGroup instanceof NioEventLoopGroup) {
channelFactory = NioSocketChannelFactory.INSTANCE;
} else {
channelFactory = getEpollSocketChannelFactory();
}

I just want to use native EventLoopGroup on MacOS.

@slandelle
Copy link
Contributor

Contributions welcome :)

@elventear
Copy link

I am experiencing the same the same issue. I would be willing to contribute a fix, but I am wondering what would be an acceptable approach. The current approach seems to be too constrained to specific implementations.

I am thinking along the lines of providing a ChannelFactory within AsyncHttpClientConfig when the EventLoopGroup is provided within the configuration.

@slandelle
Copy link
Contributor

@elventear If your use case is only to support using a KQueueEventLoopGroup, please do the same as getEpollSocketChannelFactory but test the underlying OS with io.netty.util.internal.PlatformDependent. Just make sure that things with even with netty-transport-native-kqueue in the classpath.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants