Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bower] Change main to index.js fixes bower's install process. #11

Merged
merged 1 commit into from Jul 28, 2014

Conversation

Projects
None yet
2 participants
@andreip
Copy link
Contributor

andreip commented Jul 26, 2014

Problem

I wanted to use your library without having to include it in my repo explicitly, thus use bower, but found that it wrongly installed. Try it for yourself:

$ bower cache clean
$ bower install schema-inspector
$ ls bower_components/schema-inspector
fonts       images      index.html  javascripts params.json stylesheets
$ ls bower_components/schema-inspector/javascripts/
headsmart.min.js main.js          modernizr.js

You can see that the directory structure created is wrong, I cannot use your library and the lib/ is nowhere to be found.

Fixed

I've created a repo of my own at andreip/schema-inspector-testing which I registered under the name of schema-inspector-testing with bower. The repo includes the same commit from this pull request.
You can checkout the registered repo. You'll see it creates the correct directory structure now:

$ bower search schema-inspector-testing
$ bower install schema-inspector-testing
$ ls bower_components/schema-inspector-testing/
LICENSE      Makefile     README.md    bower.json   index.js     lib          misc         package.json
$ ls bower_components/schema-inspector-testing/lib/
schema-inspector.js

NOTE: Please consider improving your bower install, I'll just have to use my own version until this is fixed.
Also, I'm no expert in this, so I may have it somehow wrong, feel free to correct me.

Atinux added a commit that referenced this pull request Jul 28, 2014

Merge pull request #11 from andreip/master
[Bower] Change main to index.js fixes bower's install process.

@Atinux Atinux merged commit be14e99 into Atinux:master Jul 28, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@Atinux

This comment has been minimized.

Copy link
Owner

Atinux commented Jul 28, 2014

Merged and published!

Thank you @andreip

$ bower install --save schema-inspector
$ ls bower_components/schema-inspector/
LICENSE      Makefile     README.md    bower.json   index.js     lib          misc         package.json
$ ls bower_components/schema-inspector/lib/
schema-inspector.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.