Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few of my patches being formatted incorrectly & fix the Minecart/Boat lag/crash exploit #13

Merged
merged 2 commits into from Apr 28, 2022

Conversation

allinkdev
Copy link
Contributor

A few of my patches didn't have correct formatting, and are modified every time you run the "rebuildPatches" task. This pull request fixes that.

Minecart/Boat crash/lag exploit is summoning a bunch of Minecart/Boats, making them move and as such collide with each other. The patch added in this pull request fully fixes that by limiting the amount of vehicle collisions to 3 and if the amount of entities they're colliding with exceeds 15, the vehicle gets deleted. Also prevents collisions for 5 seconds if the entity has collided with 4+ entities.

@VideoGameSmash12
Copy link
Contributor

Will this cause any unintentional side effects with the plugins TF has (e.g. Carz)?

@allinkdev
Copy link
Contributor Author

Will this cause any unintentional side effects with the plugins TF has (e.g. Carz)?

I think Carz only uses one Minecart as a car, so it should be fine.

@allinkdev
Copy link
Contributor Author

Will this cause any unintentional side effects with the plugins TF has (e.g. Carz)?

I have tested this on a local server and the Carz plugin uses one Minecart per Car (it also does on TF) and this won't cause any unintentional side effects with this patch. However, if you collide with 3 or more players, the collision will be ignored but this is simply the patch working.

@VideoGameSmash12 VideoGameSmash12 merged commit 6f32742 into AtlasMediaGroup:main Apr 28, 2022
2 checks passed
@VideoGameSmash12
Copy link
Contributor

Will this cause any unintentional side effects with the plugins TF has (e.g. Carz)?

I have tested this on a local server and the Carz plugin uses one Minecart per Car (it also does on TF) and this won't cause any unintentional side effects with this patch. However, if you collide with 3 or more players, the collision will be ignored but this is simply the patch working.

Excellent. Merged.

@allinkdev allinkdev deleted the minecarts branch May 17, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants