Consistency fixes (across 46 commands), additional CoreProtect integration (/dispfill and /setlever), and a critical bugfix (/setlever) (FS-162) #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…consistency, I tried to change as many as possible to use `FreedomCommand.msg` instead of `CommandSender.sendMessage` for their messages. Here are a list of the files containing those changes: * Command_adminworld.java * Command_adventure.java * Command_banip.java * Command_blockedit.java * Command_blockpvp.java * Command_cage.java * Command_cartsit.java * Command_clearchat.java * Command_clearinventory.java * Command_commandlist.java * Command_creative.java * Command_deop.java * Command_deopall.java * Command_dispfill.java * Command_doom.java * Command_gcmd.java * Command_hubworld.java * Command_inspect.java * Command_list.java * Command_lockup.java * Command_manageshop.java * Command_manuallyverify.java * Command_masterbuilderworld.java * Command_mbconfig.java * Command_moblimiter.java * Command_mp44.java * Command_mute.java * Command_nickfilter.java * Command_op.java * Command_opall.java * Command_opme.java * Command_potion.java (Also corrected the inconsistent "player not found" message's color) * Command_rank.java * Command_ride.java * Command_saconfig.java * Command_scare.java * Command_setplayerlimit.java * Command_settotalvotes.java * Command_smite.java * Command_spectator.java * Command_survival.java * Command_unblockcmd.java * Command_uncage.java * Command_unmute.java * Command_verifynoadmin.java Here are some commands I added functionality to: * Command_dispfill.java: Added some code that hooks into the CoreProtect API to log the items being removed from and added into the dispensers. * Command_setlever.java: Added some code that hooks into the CoreProtect API to log the levers being interacted with. Here's a command I fixed a critical bug in: * Command_setlever.java
Focusvity
requested changes
Apr 5, 2021
src/main/java/me/totalfreedom/totalfreedommod/command/Command_setlever.java
Outdated
Show resolved
Hide resolved
Focusvity
previously approved these changes
Apr 6, 2021
|
@AtlasMediaGroup/totalfreedom-minecraft-developers Can one of you take a look - as this doesn't have a ticket, another set of eyes is needed to ensure everything is good. |
Credit to Fleek for some of the code here. Bugs that were fixed: * [Media] showing up with an extra space at the beginning of blank messages with attachments * Admin chat using incorrect colors for its ranks in messages from Discord to Minecraft * Admin notes not sending to admins, only admin impostors
Focusvity
previously requested changes
Apr 8, 2021
src/main/java/me/totalfreedom/totalfreedommod/discord/DiscordToAdminChatListener.java
Outdated
Show resolved
Hide resolved
Paldiu
approved these changes
Apr 8, 2021
|
@Wild1145 I can't trigger Travis-CI to build so can you do it for us, please? |
Focusvity
changed the title
|
I have created a ticket (FS-162) and linked the PR to it. It's up to @Wild1145 whether he wants it merged in this update or the next update. |
|
As I've merged another PR in this should now trigger a new Travis CI Build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://forum.totalfreedom.me/d/1301-bug-report-setlever-can-crash-the-server
Make sure to review my changes to make sure I didn't fuck up somewhere down the line.
Consistency Fixes
I tried to change as many as possible to use
FreedomCommand.msginstead ofCommandSender.sendMessagefor their messages. Here are a list of the files containing those changes:Functionality Additions
Here are some commands I added functionality to:
Bugfixes
Here are some bug fixes I did:
Critical Bugfix
Here's a command I fixed a critical bug in: