New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Press R to launch homebrew launcher while launching the album applet #2

Closed
mariogamer2 opened this Issue Jun 10, 2018 · 15 comments

Comments

Projects
None yet
3 participants
@mariogamer2
Contributor

mariogamer2 commented Jun 10, 2018

I've already done some code for it, but I can't compile it (must build a 32bit toolchain)

Atmosphere-NX/Atmosphere@master...mariogamer2:master

(The loader code is not up to date, just look at the ldr_nso and ldr_npdm files)

@tumGER

This comment has been minimized.

Member

tumGER commented Jun 10, 2018

I don't think editing Atmosphere to work with it is a good solution, I'll give it a try tomorrow but I'm currently against it (or at least until we get some cleaner solution)

@mariogamer2

This comment has been minimized.

Contributor

mariogamer2 commented Jun 10, 2018

Yeah I know. I thought about this as a work-around before atmosphere's official homebrew framework comes out.

Currently building a toolchain so might test soon.

@mariogamer2

This comment has been minimized.

Contributor

mariogamer2 commented Jun 11, 2018

It might be possible to to modify the hbl, but it is harder I think.

@tumGER

This comment has been minimized.

Member

tumGER commented Jun 11, 2018

Your modification doesn't actually compile since it has some errors in it - I'm going to close this issue until A. You find an alternative solution or B. can get it compiled

@tumGER tumGER closed this Jun 11, 2018

@mariogamer2

This comment has been minimized.

Contributor

mariogamer2 commented Jun 11, 2018

Can you post the log?

@Brawl345 Brawl345 added the suggestion label Jun 11, 2018

@Brawl345

This comment has been minimized.

Collaborator

Brawl345 commented Jun 11, 2018

C:/Users/x/Downloads/Atmosphere/stratosphere/loader/source/ldr_npdm.cpp:32:20: error: unable to find numeric literal operator 'operator""D'
     if (title_id = 010000000000100D) {
                    ^~~~~~~~~~~~~~~~
C:/Users/x/Downloads/Atmosphere/stratosphere/loader/source/ldr_npdm.cpp:35:18: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
         if(kDown = KEY_R) {
            ~~~~~~^~~~~~~
C:/Users/x/Downloads/Atmosphere/stratosphere/loader/source/ldr_npdm.cpp:53:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
@mariogamer2

This comment has been minimized.

Contributor

mariogamer2 commented Jun 11, 2018

Should be fixed.

Can you build it again? (Again sorry I'm still building the toolchain)

@Brawl345

This comment has been minimized.

Collaborator

Brawl345 commented Jun 11, 2018

Nope:

C:/Users/x/Downloads/Atmosphere/stratosphere/loader/source/ldr_npdm.cpp:32:20: error: invalid conversion from 'const char*' to 'u64' {aka 'long unsigned int'} [-fpermissive]
     if (title_id = "010000000000100D") {
                    ^~~~~~~~~~~~~~~~~~
C:/Users/x/Downloads/Atmosphere/stratosphere/loader/source/ldr_npdm.cpp:32:18: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
     if (title_id = "010000000000100D") {
         ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
C:/Users/x/Downloads/Atmosphere/stratosphere/loader/source/ldr_npdm.cpp:35:18: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
         if(kDown = KEY_R) {
            ~~~~~~^~~~~~~
make[1]: *** [/opt/devkitpro/devkitA64/base_rules:14: ldr_npdm.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:118: build] Error 2
@mariogamer2

This comment has been minimized.

Contributor

mariogamer2 commented Jun 11, 2018

Try again?

@Brawl345

This comment has been minimized.

Collaborator

Brawl345 commented Jun 11, 2018

Yeah it works but editing the Makefile is an ugly workaround :P

@mariogamer2

This comment has been minimized.

Contributor

mariogamer2 commented Jun 11, 2018

Yup :p

@mariogamer2

This comment has been minimized.

Contributor

mariogamer2 commented Jun 11, 2018

Can you send the kip1?

@Brawl345

This comment has been minimized.

Collaborator

Brawl345 commented Jun 11, 2018

@mariogamer2

This comment has been minimized.

Contributor

mariogamer2 commented Jun 11, 2018

Nipe :(. I suppose it is more complex than this.

Someone can confirm fhat it does black screen?

@mariogamer2

This comment has been minimized.

Contributor

mariogamer2 commented Jul 8, 2018

Might be working.
Can you test it? (On hardware too, I an travelling)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment