New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to press R to launch into the album instead #20

Closed
tumGER opened this Issue Jul 20, 2018 · 7 comments

Comments

Projects
4 participants
@tumGER
Member

tumGER commented Jul 20, 2018

As tried in #2 and #11 by @mariogamer2 - The requirement for this is that we will have some sort of way to call hid from a sysmodule at some point so don't expect this to be done any time soon.

Now possible thanks to @jakibaki!

Closes #19

@tumGER tumGER added the suggestion label Jul 20, 2018

@tumGER tumGER added this to To do in SDFilesSwitch via automation Jul 20, 2018

@jakibaki

This comment has been minimized.

Collaborator

jakibaki commented Jul 21, 2018

@tumGER

This comment has been minimized.

Member

tumGER commented Jul 21, 2018

Oh nice, didn't expect that one :p - Thank you @jakibaki

@WerWolv98

This comment has been minimized.

Collaborator

WerWolv98 commented Jul 21, 2018

I've tried to implement it already. So far it didn't work because probably the loader gets called too early in the boot process. I'll try some more later though

@mariogamer2

This comment has been minimized.

Contributor

mariogamer2 commented Jul 21, 2018

The code should work in that case (thx @jakibaki ). I just need to initialize hid. (tho it launches album by default)

Atmosphere-NX/Atmosphere@master...mariogamer2:master

Might not work, if it doesn't, it probably need to initialize hid after the comparison.

edit: nvm the rest, the default is that it initialize in the comparison.
Here is another branch if the other doesn't work:

Atmosphere-NX/Atmosphere@master...mariogamer2:hid-in-comparison

If both work, you should use this one, since it only initialize when needed.

@mariogamer2

This comment has been minimized.

Contributor

mariogamer2 commented Jul 27, 2018

switchbrew/libnx#135 got merged :)

@mariogamer2

This comment has been minimized.

Contributor

mariogamer2 commented Aug 1, 2018

You could have waited for that v6 release. I was at the point of testing it X)

And everything is working fine. If you press R, it loads the homebrew menu. If you do nothing, it loads the album :).

@tumGER

This comment has been minimized.

Member

tumGER commented Aug 1, 2018

Hmm, I guess it's a v6.1 then :P

@tumGER tumGER closed this in #35 Aug 1, 2018

SDFilesSwitch automation moved this from In progress to Done Aug 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment