Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find alternative mechanism for data files used by docker for testing #402

Open
ansell opened this issue Sep 12, 2019 · 1 comment

Comments

@ansell
Copy link
Member

commented Sep 12, 2019

The binary files used by docker for testing have been removed. This issue is aimed at finding a sustainable git and docker friendly solution to the need for data files during integration tests.

@ansell ansell referenced this issue Sep 12, 2019
1 of 1 task complete
@djtfmartin djtfmartin removed their assignment Sep 19, 2019
@djtfmartin

This comment has been minimized.

Copy link
Member

commented Sep 19, 2019

The files are not in use during the integration tests. They where left in the repository to make the generation of the docker images (which are used by the integration tests) more easy for further development (as and when test data needs to change).
I don't have a problem with binary content in repositories - we have test JPEGs/PNGs and zips in various places, but im not prepared to argue that strongly for these files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.