New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .clang_complete files. #95

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@promethe42
Contributor

promethe42 commented Jul 30, 2015

.clang_complete files are used by other clang-based software including the autocomplete-clang Atom plugin (https://github.com/yasuyuky/autocomplete-clang) or the famous Vim clang_complete plugin (https://github.com/Rip-Rip/clang_complete).

This PR adds support for .clang_complete files using the clang-flags npm module.

This way, one can easily use existing .clang_complete files with linter-clang instead of having to create .linter-clang-flags files.

Review on Reviewable

@keplersj

This comment has been minimized.

Show comment
Hide comment
@keplersj

keplersj Jul 31, 2015

Member

I love this. In the next version of linter-clang I'm going to be removing the .linter-clang-flags feature anyway. About I close this and use this instead when this package is rewritten for Linter 1.0.0?

Member

keplersj commented Jul 31, 2015

I love this. In the next version of linter-clang I'm going to be removing the .linter-clang-flags feature anyway. About I close this and use this instead when this package is rewritten for Linter 1.0.0?

@keplersj keplersj closed this Jul 31, 2015

@keplersj

This comment has been minimized.

Show comment
Hide comment
@keplersj

keplersj Jul 31, 2015

Member

@promethe42 Could you please do this for the package as soon as #83 is merged? I've ripped out the old stuff in preparation of the .clang_complete code.

Member

keplersj commented Jul 31, 2015

@promethe42 Could you please do this for the package as soon as #83 is merged? I've ripped out the old stuff in preparation of the .clang_complete code.

@promethe42

This comment has been minimized.

Show comment
Hide comment
@promethe42

promethe42 Jul 31, 2015

Contributor

OK. When will that happen?

Contributor

promethe42 commented Jul 31, 2015

OK. When will that happen?

@keplersj

This comment has been minimized.

Show comment
Hide comment
@keplersj

keplersj Jul 31, 2015

Member

As soon as the code review finishes.

On Fri, Jul 31, 2015, 5:26 AM Jean-Marc Le Roux notifications@github.com
wrote:

OK. When will that happen?


Reply to this email directly or view it on GitHub
#95 (comment)
.

Member

keplersj commented Jul 31, 2015

As soon as the code review finishes.

On Fri, Jul 31, 2015, 5:26 AM Jean-Marc Le Roux notifications@github.com
wrote:

OK. When will that happen?


Reply to this email directly or view it on GitHub
#95 (comment)
.

@keplersj

This comment has been minimized.

Show comment
Hide comment
@keplersj

keplersj Aug 2, 2015

Member

Could you please see what it would take to implement this? Beware I have rewritten the package in ES6.

Member

keplersj commented Aug 2, 2015

Could you please see what it would take to implement this? Beware I have rewritten the package in ES6.

@keplersj

This comment has been minimized.

Show comment
Hide comment
@keplersj

keplersj Aug 2, 2015

Member

If you need any help, don't be afraid to ask.

The Atom Slack is a great place for discussion.

Member

keplersj commented Aug 2, 2015

If you need any help, don't be afraid to ask.

The Atom Slack is a great place for discussion.

@promethe42

This comment has been minimized.

Show comment
Hide comment
@promethe42

promethe42 Aug 3, 2015

Contributor

New PR #99

Contributor

promethe42 commented Aug 3, 2015

New PR #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment