New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve symlinks for PHPCS output #294

Merged
merged 4 commits into from Oct 4, 2017

Conversation

Projects
None yet
2 participants
@felipeelia
Contributor

felipeelia commented Oct 3, 2017

Problem solved:

  • textEditor.getPath() returns path with symbolic link;
  • PHPCS returns its messages indexed by file real path;
    This commit creates a fileRealPath variable and search for it into data.files.

Fixes #293.

felipeelia added some commits Oct 3, 2017

Update main.js
Problem solved:
- `textEditor.getPath()` returns path with symbolic link;
- PHPCS returns its messages indexed by file real path;
This commit creates a `fileRealPath` variable and search for it into data.files.
Show outdated Hide outdated lib/main.js

@Arcanemagus Arcanemagus changed the title from Update main.js [#293] to Resolve symlinks for PHPCS output Oct 3, 2017

@Arcanemagus

This comment has been minimized.

Show comment
Hide comment
@Arcanemagus

Arcanemagus Oct 3, 2017

Member

It looks like this has probably been an issue since Atom v1.14.0 (atom/atom#13545).

Member

Arcanemagus commented Oct 3, 2017

It looks like this has probably been an issue since Atom v1.14.0 (atom/atom#13545).

@Arcanemagus Arcanemagus added the bug label Oct 3, 2017

felipeelia added some commits Oct 3, 2017

Resolve symlinks for PHPCS output
Bringing in fs
fileRealPath as a const
create a small async wrapper and using it.
Remove unnecessary parentheses
Remove parentheses around single function argument (getFileRealPath) having a body with no curly braces
@Arcanemagus

Thanks!

@Arcanemagus Arcanemagus merged commit b825feb into AtomLinter:master Oct 4, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment