Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruins] fix leveling issues (fixes #192) #202

Merged
merged 1 commit into from May 24, 2018

Conversation

Projects
None yet
2 participants
@QuarterAnimal
Copy link
Collaborator

commented May 22, 2018

Although Insane-96's issue #192 was closed as a presumed problem with templates, it actually points to some real problems related to leveling. Various functions throughout the mod disagreed as to whether the proposed Y-coordinate of a spawning site represented the base of the structure or the surface on which it was going to spawn (i.e., one block lower); as a result, structures occasionally spawned one block higher than they should. The leveling algorithm was not necessarily able to recover the surface fill block it needed after the Y-coordinate was massaged by checkArea(). The alternate nether Y-finding algorithm was outright broken. Blocks saved for the /undo function didn't account for leveling changes below the structure.

With these changes, I don't see structures "spawn in midair" any more (aside from the ones that are supposed to, of course). Leveling looks better all around, and /undo works. I didn't have to change any of the template files to fix the problems I saw.

@AtomicStryker AtomicStryker merged commit c2c8887 into AtomicStryker:1.12.2 May 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.