Skip to content

fix appveyor #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AtsushiSakai merged 1 commit into from
Jan 12, 2019
Merged

fix appveyor #153

AtsushiSakai merged 1 commit into from
Jan 12, 2019

Conversation

@jwdinius
Copy link
Contributor

@jwdinius jwdinius commented Jan 10, 2019

No description provided.

@jwdinius jwdinius force-pushed the fix_appveyor branch 2 times, most recently from 35d10ed to a081362 Compare January 10, 2019 02:58
@coveralls
Copy link

coveralls commented Jan 10, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 701

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 83.818%
Files with Coverage Reduction New Missed Lines %
PathPlanning/RRTStarReedsShepp/rrt_star_reeds_shepp.py 2 85.08%
Totals Coverage Status
Change from base Build 686: 0.2%
Covered Lines: 6687
Relevant Lines: 7978
💛 - Coveralls

@jwdinius jwdinius force-pushed the fix_appveyor branch 9 times, most recently from 395f84b to 0857806 Compare January 10, 2019 05:03
@jwdinius jwdinius changed the title WIP: fix appveyor fix appveyor Jan 10, 2019
@jwdinius
Copy link
Contributor Author

jwdinius commented Jan 10, 2019

I was able to use the conda environment definition from the repo's environment.yml file to install all dependencies within that conda environment. This fixes the broken appveyor ci. All CI checks pass now.

@AtsushiSakai
Copy link
Owner

AtsushiSakai commented Jan 12, 2019

@jwdinius Hi. Thank you for your PR. I’m sorry my laptop is broken now, I will check it later.

@AtsushiSakai AtsushiSakai merged commit 00ce431 into AtsushiSakai:master Jan 12, 2019
@AtsushiSakai
Copy link
Owner

AtsushiSakai commented Jan 12, 2019

@jwdinius Great!!.

@AtsushiSakai
Copy link
Owner

AtsushiSakai commented Jan 12, 2019 •
edited
Loading

Close #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jwdinius @coveralls @AtsushiSakai