Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dstar #890

Closed
wants to merge 3 commits into from
Closed

fix dstar #890

wants to merge 3 commits into from

Conversation

Ts-sound
Copy link

Reference issue

fix #886

What does this implement/fix?

When you modify the map ( add obstacle ) , the untraveled paths are updated ;

@Ts-sound Ts-sound closed this Aug 16, 2023
@2892510130
Copy link
Contributor

Thanks for your PR, but there is still a little bug here: when your newly added obstacle is too long it will not work. I think the reason is that the initialization of Map is [0 -> 100], so it does not initialize points have negative x coordinate. However the obstacle, ox, have negative value. Maybe we should change the Map initialization code?

@2892510130
Copy link
Contributor

Another question: I read your code, and I find that you rerun the D* in a cloned map. Is it still a D* algorithm? D* should be abled to dynamically find a path based on previous search result, but your dstar2 is a new search without information from a previous search.

@2892510130
Copy link
Contributor

I've fixed the bug, but there's still a problem with the map initialization process (it's not a problem with the algorithm, so I don't want to waste time fixing it, haha). #896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug report: D*
2 participants