[PAY-3750] Remove dead code in web - part 1 #10897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
faridsalau
changed the title
raymondjacobson
approved these changes
Jan 3, 2025
This was referenced Jan 3, 2025
audius-infra
pushed a commit
that referenced
this pull request
Jan 4, 2025
[6928844] Revert tan-query changes on main (#10907) Andrew Mendelsohn [0f13539] [PAY-3750] Remove unused exports and dead code - part 4 (#10903) Farid Salau [fd2da0c] Switch react-lottie for lottie-react (#10905) Raymond Jacobson [4d79dda] [PAY-3750] Remove unused exports and dead code - part 3 (#10902) Farid Salau [3f3cc26] [PAY-3750] Remove unused exports and dead code - part 2 (#10901) Farid Salau [f5fc67b] Fix wrong data getting written to queryClient (#10900) Andrew Mendelsohn [0a000c7] [PAY-3750] Remove dead code in web - part 1 (#10897) Farid Salau [3074cc2] [PAY-3729] Fix issues with cover photos and challenges (#10891) Randy Schott [81f9d83] [C-5588] Replace useGetTrackById usages with useTrack (#10889) Andrew Mendelsohn [b6c0d5f] [PAY-3741] Fix playback immediately after purchase (#10895) Raymond Jacobson [f882ea1] Refactor primeData helpers (#10893) Andrew Mendelsohn [eeaa32d] Fix cache syncing (#10894) Dylan Jeffers [954e931] Misc web package cleanup (#10885) Raymond Jacobson [cf1aff3] [C-5589] Migrate collections to react query (#10886) Dylan Jeffers [6c82c79] Fix mobile prettier (#10888) Dylan Jeffers [067a5ec] [PAY-3740] Stop propagation on gated conditions pill (#10887) Raymond Jacobson [5301258] Fix SSR rendering issues (#10884) Randy Schott [ffdf3bd] [PAY-3739] Fix folder expansion (#10883) Raymond Jacobson [99dc254] [C-5587] Migrate users hooks to react query (#10881) Dylan Jeffers [3c1ce7c] [PAY-3748] Fix logged out SDK initialization (#10873) Marcus Pasell [496e3b4] Fix various console warnings (#10872) Dylan Jeffers [5e8699b] Small fix to mobile edit trackform to show artwork on upload (#10880) Kyle Shanks [553e251] [C-5582] Fix icon fill warning (#10861) Dylan Jeffers [614ece7] [C-5581] Remove default props (#10860) Dylan Jeffers [3ba3784] Fix web tests due to redux-first-history migration (#10874) Dylan Jeffers [2e4ff12] [C-5578] Replace connected-react-router with redux-first-history (#10858) Dylan Jeffers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes several unused exports across the web package that were identified using
ts-unused-exports. I've manually verified that these exports are not being used anywhere in the codebase.Changes
Details
Using the command
npx ts-unused-exports packages/web/tsconfig.json, I identified several exports that weren't being used. After manual verification to ensure these weren't being used through dynamic imports or other means, I removed or converted them to local declarations.Key changes include:
HistoryContextType,RetrieveCollectionsConfig)USER_INITIAL_LOAD_COUNT,MAX_REMIXERS)Why This Matters
Unused exports in TypeScript projects can cause several issues:
This is one of several PRs aimed at cleaning up unused exports across our codebase. Future PRs will address other packages.
How Has This Been Tested?