diff --git a/eth-contracts/contracts/DelegateManager.sol b/eth-contracts/contracts/DelegateManager.sol index c39021525a0..c8a11586f85 100644 --- a/eth-contracts/contracts/DelegateManager.sol +++ b/eth-contracts/contracts/DelegateManager.sol @@ -35,24 +35,24 @@ contract DelegateManager is InitializableV2 { address private claimsManagerAddress; /** - * Number of blocks an undelegate operation has to wait + * Period in blocks an undelegate operation is delayed. * The undelegate operation speed bump is to prevent a delegator from * attempting to remove their delegation in anticipation of a slash. - * @notice must be >= Governance.votingPeriod + * @notice Must be greater than governance votingPeriod + executionDelay */ uint256 private undelegateLockupDuration; - // Maximum number of delegators a single account can handle + /// @notice Maximum number of delegators a single account can handle uint256 private maxDelegators; - // Minimum amount of delegation allowed + /// @notice Minimum amount of delegation allowed uint256 private minDelegationAmount; /** * Lockup duration for a remove delegator request. * The remove delegator speed bump is to prevent a service provider from maliciously * removing a delegator prior to the evaluation of a proposal. - * @notice must be >= Governance.votingPeriod + * @notice Must be greater than governance votingPeriod + executionDelay */ uint256 private removeDelegatorLockupDuration; diff --git a/eth-contracts/contracts/ServiceProviderFactory.sol b/eth-contracts/contracts/ServiceProviderFactory.sol index 00c5d5f51ca..e0522faf114 100644 --- a/eth-contracts/contracts/ServiceProviderFactory.sol +++ b/eth-contracts/contracts/ServiceProviderFactory.sol @@ -26,7 +26,15 @@ contract ServiceProviderFactory is InitializableV2 { address private governanceAddress; address private serviceTypeManagerAddress; address private claimsManagerAddress; + + /// @notice Period in blocks that a decrease stake operation is delayed. + /// Must be greater than governance votingPeriod + executionDelay in order to + /// prevent pre-emptive withdrawal in anticipation of a slash proposal uint256 private decreaseStakeLockupDuration; + + /// @notice Period in blocks that an update deployer cut operation is delayed. + /// Must be greater than funding round block diff in order + /// to prevent manipulation around a funding round uint256 private deployerCutLockupDuration; /// @dev - Stores following entities