[PAY-2917] Migrate user endpoints to SDK, round 3 #9432

schottra · 2024-08-13T16:32:17Z

Description

getFavorites
getAssociatedWallets
getUserTags
getUserChallenges
getUserUndisbursedChallenges

How Has This Been Tested?

Tested locally against staging. Used compareSDKResponse to verify migrated response is equivalent.

changeset-bot · 2024-08-13T16:32:21Z

🦋 Changeset detected

Latest commit: f58f86f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@audius/sdk	Minor
@audius/sp-actions	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

gitguardian · 2024-08-13T16:32:21Z

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
13407071	Triggered	Generic High Entropy Secret	`f58f86f`	comms/Makefile	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

audius-infra · 2024-08-13T16:51:08Z

Preview this change https://demo.audius.co/pay-2917-user-endpoints-round-3

audius-infra · 2024-08-13T21:04:16Z

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @dylanjeffers @sliptype

audius-infra · 2024-08-13T21:15:08Z

Preview this change https://demo.audius.co/pay-2917-user-endpoints-round-3

sliptype · 2024-08-13T21:55:35Z

packages/mobile/ios/Podfile.lock

  FingerprintPro: c6444f5a00d1126446da664124529e754475f198
  fmt: ff9d55029c625d3757ed641535fd4a75fedc7ce9
-  glog: 035f1e36e53b355cf70f6434d161b36e7d21fecd
+  glog: c5d68082e772fa1c511173d6b30a9de2c05a69a2


Ah turns out it might be an xcode version thing: facebook/react-native#31121 (comment)

Good find! We can chat about making sure folks are on the same versions.

audius-infra · 2024-08-14T14:43:51Z

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @dylanjeffers @sliptype

audius-infra · 2024-08-14T14:54:50Z

Preview this change https://demo.audius.co/pay-2917-user-endpoints-round-3

audius-infra · 2024-08-14T15:07:59Z

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @dylanjeffers @sliptype

audius-infra · 2024-08-14T15:18:24Z

Preview this change https://demo.audius.co/pay-2917-user-endpoints-round-3

audius-infra · 2024-08-14T20:39:02Z

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @dylanjeffers @sliptype

schottra · 2024-08-14T20:39:03Z

packages/libs/src/sdk/api/challenges/ChallengesApi.ts

 } from './types'

-export class ChallengesApi extends BaseAPI {
+export class ChallengesApi extends GeneratedChallengesApi {


cc @rickyrombo
This manual implementation wasn't deriving from the generated api (likely because we weren't outputting anything there?). But it has this weird quirk of using an instance of the full API below for submitting. Double check me on this file and let me know if we should do it differently.

yep this looks good! no need to move the attestations to v1 rn.

Arguably this could extend from the full version but that's not usually what we're doing with other API clients

audius-infra · 2024-08-14T20:40:55Z

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @dylanjeffers @sliptype

rickyrombo · 2024-08-14T20:47:47Z

packages/libs/src/sdk/api/challenges/ChallengesApi.ts

 } from './types'

-export class ChallengesApi extends BaseAPI {
+export class ChallengesApi extends GeneratedChallengesApi {


yep this looks good! no need to move the attestations to v1 rn.

Arguably this could extend from the full version but that's not usually what we're doing with other API clients

rickyrombo · 2024-08-14T20:50:51Z

packages/web/src/common/store/profile/sagas.js


 export function* fetchSolanaCollectibles(user) {
-  const apiClient = yield getContext('apiClient')
+  const getSDK = yield getContext('audiusSdk')


almost wrote yield* but we're not in typescript land 👻 😨

I take it you can't use the getSDK helper here?

It might be possible, but getSDK uses yield* internally and to this day, despite going through it multiple times and thinking I get it, cannot remember what the implications are of doing that in JS. So I fell back to getContext here to be safe.

I have refreshed my knowledge and replaced this with direct calls to getSDK().

TIL that typed-redux-saga is not just type decorators, but actually replaces all of the effect creator functions (which return objects, by definition not iterable by yield*) with generator functions that wrap the effect creators and use plain yield internally! That was the piece that used to confuse me so much.

audius-infra · 2024-08-14T20:56:33Z

Preview this change https://demo.audius.co/pay-2917-user-endpoints-round-3

audius-infra · 2024-08-15T14:48:46Z

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @dylanjeffers @sliptype

audius-infra · 2024-08-15T14:59:14Z

Preview this change https://demo.audius.co/pay-2917-user-endpoints-round-3

…ts-round-3 * origin/main: (23 commits) Audius Protocol v0.6.169 wrong core defaults (#9452) Don't decrypt plaintext messages (#9448) [QA-1495] Fix 404 for users (#9451) [PAY-3227] Unfurl tracks in composer (#9434) Compose Solana Client in SDK (#9441) Create ChatBlast from web (#9447) [PAY-3341] Add is_plaintext field for chat message (#9442) use const for constants (#9446) core default values (#9445) Rename Targeted Message to Chat Blast (#9443) [C-4964] Comment header changes (#9444) [PAY-3310] Chat blast function in sdk (#9436) Move comments context to common (#9440) [C-4910] Comments replys & deletes fixes (#9437) Audius Protocol v0.6.168 [PAY-3106][PAY-2914] Use SDK to withdraw USDC (#9419) Add social signup feature flag (#9439) use comet repo and modd for hotreloading (#9431) Fix duplicate error name in sentry (#9430) ...

audius-infra · 2024-08-15T15:41:45Z

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @dylanjeffers @sliptype

audius-infra · 2024-08-15T15:57:50Z

Preview this change https://demo.audius.co/pay-2917-user-endpoints-round-3

[11bf6e3] Don't decrypt plaintext chat.last_message (#9470) Reed [5ba67f8] Fix chat deadlock (#9460) Reed [fbb4256] [PAY-2917] Migrate user endpoints to SDK, round 3 (#9432) Randy Schott [77814a9] bump web3 version for ci (#9457) alecsavvy [2c1679a] [PAY-3307] Upgrade chat blasts to chats in sdk (V2) (#9453) Reed [279a9b2] More explicit audience columns for chat blast. (#9454) Steve Perkins

[d712b07] [C-4939] Add comment action menu popup (#9472) JD Francis [641c9c1] [C-4940] Add comment badges (desktop web) (#9475) JD Francis [aca7b5c] [PAY-3315][PAY-3316][PAY-3323] Staking bridge (#9408) Saliou Diallo [bdc139a] [C-4828] Add timestamp features to comments (#9455) JD Francis [3457aeb] [QA-1504] Fix payout wallet set default (#9467) Raymond Jacobson [8c127d0] Add comment replies pagination (#9435) Isaac Solo [c5e250e] [C-4929] Add SendIcon component to harmony and harmony native (#9422) Kyle Shanks [a17b30e] Hook up client blast params to sdk (#9466) Reed [11bf6e3] Don't decrypt plaintext chat.last_message (#9470) Reed [bcaebb0] fix TS error (#9468) JD Francis [bb802b7] Optimistic add chat blasts (#9463) Reed [b5de040] Fix bad claimable challenge state due to nullable max_steps (#9461) Randy Schott [d4c34c3] Fix comment delete in audius-query (#9462) JD Francis [95380d8] [C-4800] Scaffolding for mobile comments (#9449) Sebastian Klingler [fbb4256] [PAY-2917] Migrate user endpoints to SDK, round 3 (#9432) Randy Schott [2c1679a] [PAY-3307] Upgrade chat blasts to chats in sdk (V2) (#9453) Reed [279a9b2] More explicit audience columns for chat blast. (#9454) Steve Perkins [acb857e] Fix bug in profile page 404 (#9456) Raymond Jacobson [c382e82] Don't decrypt plaintext messages (#9448) Reed [172f172] [QA-1495] Fix 404 for users (#9451) Raymond Jacobson [82ab743] [PAY-3227] Unfurl tracks in composer (#9434) Raymond Jacobson [363af71] Compose Solana Client in SDK (#9441) Marcus Pasell [83260f6] Create ChatBlast from web (#9447) Andrew Mendelsohn [19e3bdf] [PAY-3341] Add is_plaintext field for chat message (#9442) Steve Perkins [e25c679] Rename Targeted Message to Chat Blast (#9443) Reed [fc0604c] [C-4964] Comment header changes (#9444) JD Francis [f9e4525] [PAY-3310] Chat blast function in sdk (#9436) Reed [910b655] Move comments context to common (#9440) JD Francis [bb5eaa1] [C-4910] Comments replys & deletes fixes (#9437) JD Francis [1072f5a] [PAY-3106][PAY-2914] Use SDK to withdraw USDC (#9419) Marcus Pasell [1b7bd47] Add social signup feature flag (#9439) Sebastian Klingler [4130f42] Fix duplicate error name in sentry (#9430) Marcus Pasell [54a5a78] [PAY-3300] Chat blast: lazy create thread (#9424) Steve Perkins [ca71d76] [C-4910] Audius-query-ify comments state management (#9423) JD Francis [20a55e9] [PAY-2917][QA-1466] Migrate more users endpoints (#9308) Randy Schott [ab38869] [QA-1434] Fix hanging uploads due to errors on mobile (#9420) Randy Schott [f6ab71c] Add buy button metrics (#9428) Isaac Solo [06ee8a1] Fix pagination args (#9425) Isaac Solo [b91437a] [QA-1501] Fix mobile search input (#9426) Sebastian Klingler [a3c15fd] [C-4932] Add CommentBody component to harmony and harmony-native (#9415) Kyle Shanks

pull-request-size bot added the size/M label Aug 13, 2024

schottra added 2 commits August 13, 2024 12:32

migrate audius-query usage of favorites

38a9592

migrate usage in download saga

5475d55

schottra force-pushed the pay-2917-user-endpoints-round-3 branch from e4b7a50 to 5475d55 Compare August 13, 2024 16:32

schottra added 3 commits August 13, 2024 16:21

migrate remaining getFavorites calls

5d38c8d

remove apiClient impl

3ad9bd2

migrate getAssociatedWallets calls

ef1c64a

pull-request-size bot added size/L and removed size/M labels Aug 13, 2024

sliptype approved these changes Aug 13, 2024

View reviewed changes

migrate getAssociatedWalletUserId

96351b6

migrate getUserTags

398c687

schottra added 2 commits August 14, 2024 15:27

add challenges to SDK

0f6eb90

migrate challenges endpoints

e8b1287

pull-request-size bot added size/XXL and removed size/L labels Aug 14, 2024

schottra requested review from rickyrombo and sliptype August 14, 2024 20:36

changeset

82f6711

schottra commented Aug 14, 2024

View reviewed changes

rickyrombo approved these changes Aug 14, 2024

View reviewed changes

switch to getSDK

c128f82

schottra enabled auto-merge (squash) August 15, 2024 15:38

sliptype approved these changes Aug 15, 2024

View reviewed changes

schottra disabled auto-merge August 15, 2024 16:14

schottra merged commit fbb4256 into main Aug 15, 2024

schottra deleted the pay-2917-user-endpoints-round-3 branch August 15, 2024 17:13

schottra mentioned this pull request Aug 15, 2024

Fix bad claimable challenge state due to nullable max_steps #9461

Merged

[PAY-2917] Migrate user endpoints to SDK, round 3 #9432

[PAY-2917] Migrate user endpoints to SDK, round 3 #9432

Uh oh!

Conversation

schottra commented Aug 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Uh oh!

changeset-bot bot commented Aug 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

gitguardian bot commented Aug 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Uh oh!

audius-infra commented Aug 13, 2024

Uh oh!

audius-infra commented Aug 13, 2024

Uh oh!

audius-infra commented Aug 13, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Aug 14, 2024

Uh oh!

audius-infra commented Aug 14, 2024

Uh oh!

audius-infra commented Aug 14, 2024

Uh oh!

audius-infra commented Aug 14, 2024

Uh oh!

audius-infra commented Aug 14, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Aug 14, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Aug 14, 2024

Uh oh!

audius-infra commented Aug 15, 2024

Uh oh!

audius-infra commented Aug 15, 2024

Uh oh!

audius-infra commented Aug 15, 2024

Uh oh!

audius-infra commented Aug 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

schottra commented Aug 13, 2024 •

edited

Loading

changeset-bot bot commented Aug 13, 2024 •

edited

Loading

gitguardian bot commented Aug 13, 2024 •

edited

Loading