[C-4800] Scaffolding for mobile comments #9449

sliptype · 2024-08-14T22:15:44Z

Description

Add mobile comment components, mostly copied from web
This is still pretty rough, just wanted to get something in place to start addressing the finer details

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

changeset-bot · 2024-08-14T22:15:48Z

⚠️ No Changeset found

Latest commit: 25b8e11

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

gitguardian · 2024-08-14T22:15:48Z

⚠️ GitGuardian has uncovered 9 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
11648676	Triggered	Generic High Entropy Secret	`a05a6ba`	core/infra/dev_config/discovery-one.env	View secret
11648676	Triggered	Generic High Entropy Secret	`a05a6ba`	core/infra/dev_config/discovery-one.docker.env	View secret
11648678	Triggered	Generic High Entropy Secret	`a05a6ba`	core/infra/dev_config/content-three.docker.env	View secret
11648678	Triggered	Generic High Entropy Secret	`a05a6ba`	core/infra/dev_config/content-three.env	View secret
11648679	Triggered	Generic High Entropy Secret	`a05a6ba`	core/infra/dev_config/content-two.env	View secret
11648679	Triggered	Generic High Entropy Secret	`a05a6ba`	core/infra/dev_config/content-two.docker.env	View secret
11648680	Triggered	Generic High Entropy Secret	`a05a6ba`	core/infra/dev_config/content-one.env	View secret
11648680	Triggered	Generic High Entropy Secret	`a05a6ba`	core/infra/dev_config/content-one.docker.env	View secret
13407071	Triggered	Generic High Entropy Secret	`e448012`	comms/Makefile	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

sliptype · 2024-08-14T22:20:31Z

packages/mobile/src/components/comments/CommentDrawer.tsx

+  return (
+    <Flex>
+      {comments.length === 0 ? <NoComments /> : null}
+      <FlatList


This may need to be a SectionList, need to think through how to display comments for best scrolling performance

audius-infra · 2024-08-15T15:48:14Z

Preview this change https://demo.audius.co/sk-c-4800-mobile-comments

DejayJD

From a code POV this is looking great 👌

DejayJD · 2024-08-15T17:45:35Z

packages/mobile/src/components/comments/CommentBlock.tsx

+        {/* TODO: this will be a user link but wont work with mock data */}
+        <Flex direction='row' gap='s' alignItems='center'>
+          <UserLink userId={userId} />
+          {/* TODO: figure out date from created_at */}
+          <Flex direction='row' gap='xs' alignItems='center' h='100%'>
+            {/* TODO: do we want this comment date changing on rerender? Or is that weird */}


I think we can just remove all these TODOs that I left, they're all moot now I think

DejayJD · 2024-08-15T17:51:45Z

packages/mobile/src/components/comments/CommentThread.tsx

+    id: commentId
+  })
+  const { handleLoadMoreReplies } = useCurrentCommentSection()
+  // TODO: this feels sub-optimal? Maybe fine


Another todo thats fine to remove

DejayJD · 2024-08-15T17:52:55Z

packages/mobile/src/components/comments/NoComments.tsx

+  subtitle: 'Be the first to comment on this track' // TODO: make this derive from entity type
+}
+
+export const NoComments = () => (


Is this a dupe of what you have in CommentSection?

No it's slightly different! CommentSection is just the small preview, NoComments is what we show in the drawer. Although theoretically a user shouldn't be able to open the drawer if there are no comments

DejayJD · 2024-08-15T17:53:57Z

packages/mobile/src/components/comments/mock-data.ts

+    userId: '345',
+    message: 'This is the first comment!!',
+    isPinned: true,
+    timestampS: 12,


a note for later- once my PR #9455 goes in this will likely break via TS - replaced by trackTimestampS

DejayJD · 2024-08-15T17:55:59Z

packages/mobile/src/components/comments/CommentBlock.tsx

+          {/* TODO: figure out date from created_at */}
+          <Flex direction='row' gap='xs' alignItems='center' h='100%'>
+            {/* TODO: do we want this comment date changing on rerender? Or is that weird */}
+            <Text size='s'> {formatCommentDate(createdAt)} </Text>


You can replace this with the harmony Timestamp component that KJ made
e.g. <Timestamp time={createdAtDate} />

DejayJD · 2024-08-15T17:56:21Z

packages/mobile/src/utils/comments.ts

+import dayjs from 'dayjs'
+
+// TODO: move to common once web/mobile are both up to date
+export const formatCommentDate = (dateStr: string) => {


If you use the Timestamp component this method can be deleted

Sweet, yup will do

audius-infra · 2024-08-15T18:33:48Z

Preview this change https://demo.audius.co/sk-c-4800-mobile-comments

…k-endpoints-1 * origin/main: [C-4828] Add timestamp features to comments (#9455) [QA-1504] Fix payout wallet set default (#9467) Add comment replies pagination (#9435) Audius Protocol v0.6.170 change pg string for regex in content (core) (#9471) [C-4929] Add SendIcon component to harmony and harmony native (#9422) Hook up client blast params to sdk (#9466) Don't decrypt plaintext chat.last_message (#9470) fix TS error (#9468) default connection strings (#9465) Fix malformed json in auto-approve script (#9464) Optimistic add chat blasts (#9463) Fix bad claimable challenge state due to nullable max_steps (#9461) Fix comment delete in audius-query (#9462) Fix chat deadlock (#9460) [C-4800] Scaffolding for mobile comments (#9449) Use quotes to escape job name for jq (#9459)

[d712b07] [C-4939] Add comment action menu popup (#9472) JD Francis [641c9c1] [C-4940] Add comment badges (desktop web) (#9475) JD Francis [aca7b5c] [PAY-3315][PAY-3316][PAY-3323] Staking bridge (#9408) Saliou Diallo [bdc139a] [C-4828] Add timestamp features to comments (#9455) JD Francis [3457aeb] [QA-1504] Fix payout wallet set default (#9467) Raymond Jacobson [8c127d0] Add comment replies pagination (#9435) Isaac Solo [c5e250e] [C-4929] Add SendIcon component to harmony and harmony native (#9422) Kyle Shanks [a17b30e] Hook up client blast params to sdk (#9466) Reed [11bf6e3] Don't decrypt plaintext chat.last_message (#9470) Reed [bcaebb0] fix TS error (#9468) JD Francis [bb802b7] Optimistic add chat blasts (#9463) Reed [b5de040] Fix bad claimable challenge state due to nullable max_steps (#9461) Randy Schott [d4c34c3] Fix comment delete in audius-query (#9462) JD Francis [95380d8] [C-4800] Scaffolding for mobile comments (#9449) Sebastian Klingler [fbb4256] [PAY-2917] Migrate user endpoints to SDK, round 3 (#9432) Randy Schott [2c1679a] [PAY-3307] Upgrade chat blasts to chats in sdk (V2) (#9453) Reed [279a9b2] More explicit audience columns for chat blast. (#9454) Steve Perkins [acb857e] Fix bug in profile page 404 (#9456) Raymond Jacobson [c382e82] Don't decrypt plaintext messages (#9448) Reed [172f172] [QA-1495] Fix 404 for users (#9451) Raymond Jacobson [82ab743] [PAY-3227] Unfurl tracks in composer (#9434) Raymond Jacobson [363af71] Compose Solana Client in SDK (#9441) Marcus Pasell [83260f6] Create ChatBlast from web (#9447) Andrew Mendelsohn [19e3bdf] [PAY-3341] Add is_plaintext field for chat message (#9442) Steve Perkins [e25c679] Rename Targeted Message to Chat Blast (#9443) Reed [fc0604c] [C-4964] Comment header changes (#9444) JD Francis [f9e4525] [PAY-3310] Chat blast function in sdk (#9436) Reed [910b655] Move comments context to common (#9440) JD Francis [bb5eaa1] [C-4910] Comments replys & deletes fixes (#9437) JD Francis [1072f5a] [PAY-3106][PAY-2914] Use SDK to withdraw USDC (#9419) Marcus Pasell [1b7bd47] Add social signup feature flag (#9439) Sebastian Klingler [4130f42] Fix duplicate error name in sentry (#9430) Marcus Pasell [54a5a78] [PAY-3300] Chat blast: lazy create thread (#9424) Steve Perkins [ca71d76] [C-4910] Audius-query-ify comments state management (#9423) JD Francis [20a55e9] [PAY-2917][QA-1466] Migrate more users endpoints (#9308) Randy Schott [ab38869] [QA-1434] Fix hanging uploads due to errors on mobile (#9420) Randy Schott [f6ab71c] Add buy button metrics (#9428) Isaac Solo [06ee8a1] Fix pagination args (#9425) Isaac Solo [b91437a] [QA-1501] Fix mobile search input (#9426) Sebastian Klingler [a3c15fd] [C-4932] Add CommentBody component to harmony and harmony-native (#9415) Kyle Shanks

sliptype added 10 commits August 12, 2024 16:50

Add comment section

c6d22e9

Add comment form

5097a22

Merge branch 'main' into sk-c-4800-mobile-comments

a05a6ba

Merge branch 'main' into sk-c-4800-mobile-comments

13093ee

Add CommentBlock

70d4118

Add CommentDrawer

a4234bf

Lint fix

8dc7d02

Merge branch 'main' into sk-c-4800-mobile-comments

e448012

Revert icon change

c32ede0

Styling tweaks

d722e62

sliptype requested review from DejayJD and Kyle-Shanks August 14, 2024 22:15

pull-request-size bot added the size/XL label Aug 14, 2024

Clean up

8947b71

sliptype commented Aug 14, 2024

View reviewed changes

Merge branch 'main' into sk-c-4800-mobile-comments

089c74a

DejayJD approved these changes Aug 15, 2024

View reviewed changes

Address pr comments

25b8e11

sliptype merged commit 95380d8 into main Aug 15, 2024

sliptype deleted the sk-c-4800-mobile-comments branch August 15, 2024 18:34

[C-4800] Scaffolding for mobile comments #9449

[C-4800] Scaffolding for mobile comments #9449

Uh oh!

Conversation

sliptype commented Aug 14, 2024

Description

How Has This Been Tested?

Uh oh!

changeset-bot bot commented Aug 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

gitguardian bot commented Aug 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 9 secrets following the scan of your pull request.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Aug 15, 2024

Uh oh!

DejayJD left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Aug 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

changeset-bot bot commented Aug 14, 2024 •

edited

Loading

gitguardian bot commented Aug 14, 2024 •

edited

Loading

DejayJD left a comment •

edited

Loading