[C-4828] Add timestamp features to comments #9455

DejayJD · 2024-08-15T16:01:39Z

Description

Sets up sending timestamps on desktop & clicking timestamps seeking the track player.
Fixes a couple e2e issues I found in the process with submitting timestamps.

TODO:

A bug right now is that if the song isn't already playing, it doesn't seek properly (just plays the song). I want to test more after getting the backend changes into staging (its less fun to test locally)

How Has This Been Tested?

local stack

changeset-bot · 2024-08-15T16:01:43Z

⚠️ No Changeset found

Latest commit: 4bd3fa8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

isaacsolo · 2024-08-15T16:08:55Z

packages/common/src/api/comments.ts

          message: body,
          isPinned: false,
-          timestampS,
+          trackTimestampMs,


maybe we should be using seconds? for longer things like podcasts this number can get pretty large. either way should be fine though because max postgres int will store 596 hours in ms. it's just a really big number

yeah I think seconds might be better; I'll pivot it in this PR real quick

audius-infra · 2024-08-15T16:17:00Z

Preview this change https://demo.audius.co/jd/comments-track-player-features

sliptype

Awesome!

sliptype · 2024-08-15T16:10:48Z

packages/common/src/utils/formatTrackTimestamp.ts

empty file?

🙈 no clue why this didnt get deleted lol

sliptype · 2024-08-15T16:19:43Z

packages/web/src/components/comments/CommentForm.tsx


 type CommentFormProps = {
-  onSubmit: (commentMessage: string) => void
+  handleSubmit?: ({ commentMessage }: { commentMessage: string }) => void


We usually use onSubmit as the name for the prop and then handleSubmit is the function implementation in a component

Fwiw this was intentional; my goal was to signal that this is a replacement submit handler, not an additive thing.

BUT that being said I think I'm gonna rework this and put the edit submission inside here. A bit mixed up how it currently is 😅

sliptype · 2024-08-15T16:23:10Z

packages/web/src/components/comments/CommentForm.tsx

    SquareSizes.SIZE_150_BY_150
  )

  const handleSubmit = ({ commentMessage }: CommentFormValues) => {


I think you could do this to make the default behavior a littler more clear:

const handleSubmit = (formValues: CommentFormValues) => { if (onSubmit) { onSubmit(formValues) } else { const { commentMessage } = formValues handlePostComment(commentMessage) } }

…jd/comments-track-player-features # Conflicts: # packages/common/src/context/commentsContext.tsx # packages/web/src/components/comments/CommentSectionDesktop.tsx # packages/web/src/pages/track-page/components/desktop/TrackPage.tsx

gitguardian · 2024-08-15T17:42:08Z

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
13407071	Triggered	Generic High Entropy Secret	`a866028`	comms/Makefile	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

audius-infra · 2024-08-15T18:00:57Z

Preview this change https://demo.audius.co/jd/comments-track-player-features

audius-infra · 2024-08-15T18:15:13Z

Preview this change https://demo.audius.co/jd/comments-track-player-features

…jd/comments-track-player-features

audius-infra · 2024-08-15T20:02:02Z

Preview this change https://demo.audius.co/jd/comments-track-player-features

…jd/comments-track-player-features

audius-infra · 2024-08-16T15:46:31Z

Preview this change https://demo.audius.co/jd/comments-track-player-features

…jd/comments-track-player-features # Conflicts: # packages/discovery-provider/src/api/v1/comments.py

audius-infra · 2024-08-16T17:56:29Z

Preview this change https://demo.audius.co/jd/comments-track-player-features

…k-endpoints-1 * origin/main: [C-4828] Add timestamp features to comments (#9455) [QA-1504] Fix payout wallet set default (#9467) Add comment replies pagination (#9435) Audius Protocol v0.6.170 change pg string for regex in content (core) (#9471) [C-4929] Add SendIcon component to harmony and harmony native (#9422) Hook up client blast params to sdk (#9466) Don't decrypt plaintext chat.last_message (#9470) fix TS error (#9468) default connection strings (#9465) Fix malformed json in auto-approve script (#9464) Optimistic add chat blasts (#9463) Fix bad claimable challenge state due to nullable max_steps (#9461) Fix comment delete in audius-query (#9462) Fix chat deadlock (#9460) [C-4800] Scaffolding for mobile comments (#9449) Use quotes to escape job name for jq (#9459)

[d712b07] [C-4939] Add comment action menu popup (#9472) JD Francis [641c9c1] [C-4940] Add comment badges (desktop web) (#9475) JD Francis [aca7b5c] [PAY-3315][PAY-3316][PAY-3323] Staking bridge (#9408) Saliou Diallo [bdc139a] [C-4828] Add timestamp features to comments (#9455) JD Francis [3457aeb] [QA-1504] Fix payout wallet set default (#9467) Raymond Jacobson [8c127d0] Add comment replies pagination (#9435) Isaac Solo [c5e250e] [C-4929] Add SendIcon component to harmony and harmony native (#9422) Kyle Shanks [a17b30e] Hook up client blast params to sdk (#9466) Reed [11bf6e3] Don't decrypt plaintext chat.last_message (#9470) Reed [bcaebb0] fix TS error (#9468) JD Francis [bb802b7] Optimistic add chat blasts (#9463) Reed [b5de040] Fix bad claimable challenge state due to nullable max_steps (#9461) Randy Schott [d4c34c3] Fix comment delete in audius-query (#9462) JD Francis [95380d8] [C-4800] Scaffolding for mobile comments (#9449) Sebastian Klingler [fbb4256] [PAY-2917] Migrate user endpoints to SDK, round 3 (#9432) Randy Schott [2c1679a] [PAY-3307] Upgrade chat blasts to chats in sdk (V2) (#9453) Reed [279a9b2] More explicit audience columns for chat blast. (#9454) Steve Perkins [acb857e] Fix bug in profile page 404 (#9456) Raymond Jacobson [c382e82] Don't decrypt plaintext messages (#9448) Reed [172f172] [QA-1495] Fix 404 for users (#9451) Raymond Jacobson [82ab743] [PAY-3227] Unfurl tracks in composer (#9434) Raymond Jacobson [363af71] Compose Solana Client in SDK (#9441) Marcus Pasell [83260f6] Create ChatBlast from web (#9447) Andrew Mendelsohn [19e3bdf] [PAY-3341] Add is_plaintext field for chat message (#9442) Steve Perkins [e25c679] Rename Targeted Message to Chat Blast (#9443) Reed [fc0604c] [C-4964] Comment header changes (#9444) JD Francis [f9e4525] [PAY-3310] Chat blast function in sdk (#9436) Reed [910b655] Move comments context to common (#9440) JD Francis [bb5eaa1] [C-4910] Comments replys & deletes fixes (#9437) JD Francis [1072f5a] [PAY-3106][PAY-2914] Use SDK to withdraw USDC (#9419) Marcus Pasell [1b7bd47] Add social signup feature flag (#9439) Sebastian Klingler [4130f42] Fix duplicate error name in sentry (#9430) Marcus Pasell [54a5a78] [PAY-3300] Chat blast: lazy create thread (#9424) Steve Perkins [ca71d76] [C-4910] Audius-query-ify comments state management (#9423) JD Francis [20a55e9] [PAY-2917][QA-1466] Migrate more users endpoints (#9308) Randy Schott [ab38869] [QA-1434] Fix hanging uploads due to errors on mobile (#9420) Randy Schott [f6ab71c] Add buy button metrics (#9428) Isaac Solo [06ee8a1] Fix pagination args (#9425) Isaac Solo [b91437a] [QA-1501] Fix mobile search input (#9426) Sebastian Klingler [a3c15fd] [C-4932] Add CommentBody component to harmony and harmony-native (#9415) Kyle Shanks

[aca7b5c] [PAY-3315][PAY-3316][PAY-3323] Staking bridge (#9408) Saliou Diallo [bdc139a] [C-4828] Add timestamp features to comments (#9455) JD Francis [8c127d0] Add comment replies pagination (#9435) Isaac Solo

Add timestamp features to comments

1903f4c

DejayJD requested review from Kyle-Shanks and isaacsolo and removed request for Kyle-Shanks August 15, 2024 16:01

pull-request-size bot added the size/L label Aug 15, 2024

DejayJD requested review from Kyle-Shanks, isaacsolo and sliptype and removed request for isaacsolo August 15, 2024 16:01

remove comment

cdaf0f2

isaacsolo reviewed Aug 15, 2024

View reviewed changes

sliptype approved these changes Aug 15, 2024

View reviewed changes

DejayJD added 4 commits August 15, 2024 11:46

rename ms to s

fb68b94

Move edit logic into CommentForm

74da011

fix edit

f4ea6e0

fix ts + remove comments

e78b708

DejayJD mentioned this pull request Aug 15, 2024

[C-4800] Scaffolding for mobile comments #9449

Merged

Merge branch 'main' of github.com:AudiusProject/audius-protocol into …

33dab8d

…jd/comments-track-player-features

DejayJD added 2 commits August 16, 2024 10:15

Merge branch 'main' of github.com:AudiusProject/audius-protocol into …

b251016

…jd/comments-track-player-features

fix types post-merge

7765019

DejayJD added 2 commits August 16, 2024 11:51

Merge branch 'main' of github.com:AudiusProject/audius-protocol into …

85f54e3

…jd/comments-track-player-features # Conflicts: # packages/discovery-provider/src/api/v1/comments.py

Fix merge quirk

4bd3fa8

DejayJD enabled auto-merge (squash) August 16, 2024 17:57

DejayJD merged commit bdc139a into main Aug 16, 2024

DejayJD deleted the jd/comments-track-player-features branch August 16, 2024 18:05

[C-4828] Add timestamp features to comments #9455

[C-4828] Add timestamp features to comments #9455

Uh oh!

Conversation

DejayJD commented Aug 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Uh oh!

changeset-bot bot commented Aug 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

isaacsolo Aug 15, 2024

Choose a reason for hiding this comment

Uh oh!

DejayJD Aug 15, 2024

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Aug 15, 2024

Uh oh!

sliptype left a comment

Choose a reason for hiding this comment

Uh oh!

sliptype Aug 15, 2024

Choose a reason for hiding this comment

Uh oh!

DejayJD Aug 15, 2024

Choose a reason for hiding this comment

Uh oh!

sliptype Aug 15, 2024

Choose a reason for hiding this comment

Uh oh!

DejayJD Aug 15, 2024

Choose a reason for hiding this comment

Uh oh!

sliptype Aug 15, 2024

Choose a reason for hiding this comment

Uh oh!

gitguardian bot commented Aug 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Uh oh!

audius-infra commented Aug 15, 2024

Uh oh!

audius-infra commented Aug 15, 2024

Uh oh!

audius-infra commented Aug 15, 2024

Uh oh!

audius-infra commented Aug 16, 2024

Uh oh!

audius-infra commented Aug 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

DejayJD commented Aug 15, 2024 •

edited

Loading

changeset-bot bot commented Aug 15, 2024 •

edited

Loading

gitguardian bot commented Aug 15, 2024 •

edited

Loading