[C-4940] Add comment badges (desktop web) #9475
Conversation
|
There was a problem hiding this comment.
How are you using the mock data now btw? I have a change locally to return it from api/comments. But I had to move mock-data.ts to common
There was a problem hiding this comment.
I'm not using it any more tbh, can probably just delete the web one. Now most things are implemented in the context & the backend in staging so haven't really needed the mock data.
Right now the only main things unfinished on the backend are just pinning, hearting, and sorting - but optimistic updates should let you test whatever you need tbh.
If you're up to date on the context you should probably move over as well so we can just remove the mock data and not have to bother updating it (unless we want to keep it around as sample data, maybe for tests down the road 🤷); imo it is somewhat cumbersome to keep it in sync with all the model changes we're doing right now, so we can delete or comment it out for now.
There was a problem hiding this comment.
I do like the idea of keeping it around for testing. Honestly it's pretty helpful right now because I'm just immediately showing the comment drawer on app start with mock data, which makes the feedback cycle way shorter than having to navigate to a track over and over again lol
Having a single set of data that covers all of our edge cases will be useful for doing eng qa before we do real qa too
There was a problem hiding this comment.
Fair! If its valuable to you lets def keep it, but yeah moving to common is good 👍.
Also we could maybe plug in a prop to the context to use mock data or something 🤔
There was a problem hiding this comment.
Also yeah I'm secretly hoping that we're able to move quick enough on this stuff that we can easily find time to write some integration tests.
While I admit I could be writing them now, personally I've been holding off just to save time in case we get squeezed for time later down the road. But at the moment it's looking to me like we're moving quick enough that we can scope them in without any issues 👀
|
Preview this change https://demo.audius.co/jd/comment-badges |
[d712b07] [C-4939] Add comment action menu popup (#9472) JD Francis [641c9c1] [C-4940] Add comment badges (desktop web) (#9475) JD Francis [aca7b5c] [PAY-3315][PAY-3316][PAY-3323] Staking bridge (#9408) Saliou Diallo [bdc139a] [C-4828] Add timestamp features to comments (#9455) JD Francis [3457aeb] [QA-1504] Fix payout wallet set default (#9467) Raymond Jacobson [8c127d0] Add comment replies pagination (#9435) Isaac Solo [c5e250e] [C-4929] Add SendIcon component to harmony and harmony native (#9422) Kyle Shanks [a17b30e] Hook up client blast params to sdk (#9466) Reed [11bf6e3] Don't decrypt plaintext chat.last_message (#9470) Reed [bcaebb0] fix TS error (#9468) JD Francis [bb802b7] Optimistic add chat blasts (#9463) Reed [b5de040] Fix bad claimable challenge state due to nullable max_steps (#9461) Randy Schott [d4c34c3] Fix comment delete in audius-query (#9462) JD Francis [95380d8] [C-4800] Scaffolding for mobile comments (#9449) Sebastian Klingler [fbb4256] [PAY-2917] Migrate user endpoints to SDK, round 3 (#9432) Randy Schott [2c1679a] [PAY-3307] Upgrade chat blasts to chats in sdk (V2) (#9453) Reed [279a9b2] More explicit audience columns for chat blast. (#9454) Steve Perkins [acb857e] Fix bug in profile page 404 (#9456) Raymond Jacobson [c382e82] Don't decrypt plaintext messages (#9448) Reed [172f172] [QA-1495] Fix 404 for users (#9451) Raymond Jacobson [82ab743] [PAY-3227] Unfurl tracks in composer (#9434) Raymond Jacobson [363af71] Compose Solana Client in SDK (#9441) Marcus Pasell [83260f6] Create ChatBlast from web (#9447) Andrew Mendelsohn [19e3bdf] [PAY-3341] Add is_plaintext field for chat message (#9442) Steve Perkins [e25c679] Rename Targeted Message to Chat Blast (#9443) Reed [fc0604c] [C-4964] Comment header changes (#9444) JD Francis [f9e4525] [PAY-3310] Chat blast function in sdk (#9436) Reed [910b655] Move comments context to common (#9440) JD Francis [bb5eaa1] [C-4910] Comments replys & deletes fixes (#9437) JD Francis [1072f5a] [PAY-3106][PAY-2914] Use SDK to withdraw USDC (#9419) Marcus Pasell [1b7bd47] Add social signup feature flag (#9439) Sebastian Klingler [4130f42] Fix duplicate error name in sentry (#9430) Marcus Pasell [54a5a78] [PAY-3300] Chat blast: lazy create thread (#9424) Steve Perkins [ca71d76] [C-4910] Audius-query-ify comments state management (#9423) JD Francis [20a55e9] [PAY-2917][QA-1466] Migrate more users endpoints (#9308) Randy Schott [ab38869] [QA-1434] Fix hanging uploads due to errors on mobile (#9420) Randy Schott [f6ab71c] Add buy button metrics (#9428) Isaac Solo [06ee8a1] Fix pagination args (#9425) Isaac Solo [b91437a] [QA-1501] Fix mobile search input (#9426) Sebastian Klingler [a3c15fd] [C-4932] Add CommentBody component to harmony and harmony-native (#9415) Kyle Shanks
Description
How Has This Been Tested?
web:stage - used Isaac as a test tipper 👌